Re: class BuildTimeoutException extends BuildException

2010-10-28 Thread Jesse Glick
On 10/28/2010 06:17 AM, Steve Loughran wrote: Ant uses getMessage() primarily to extract some text from BuildException to use in a log or other exception. Probably this should be fixed to use getLocalizedMessage(), if only for consistency with Throwable.printStackTrace. -

Re: class BuildTimeoutException extends BuildException

2010-10-28 Thread Steve Loughran
On 27/10/10 18:34, Jesse Glick wrote: On 10/27/2010 06:01 AM, Steve Loughran wrote: 4. we leave the error strings alone for fear of [...fear itself?] #4 irritates me, I'd like some details about which subprocess got killed, but if we are searching for the string in Ant's own codebase, then we c

Re: class BuildTimeoutException extends BuildException

2010-10-27 Thread Antoine Levy-Lambert
On 10/27/10 12:33 PM, Steve Loughran wrote: > > I'm thinking of being ruthless and doing the move on the basis that > that funtest task was never documented (my fault) and therefore > doesn't exist, we can move it without guilt. Therefore I am now > thinking of > > -move the existing BuildTimeoutEx

Re: class BuildTimeoutException extends BuildException

2010-10-27 Thread Jesse Glick
On 10/27/2010 06:01 AM, Steve Loughran wrote: 4. we leave the error strings alone for fear of [...fear itself?] #4 irritates me, I'd like some details about which subprocess got killed, but if we are searching for the string in Ant's own codebase, then we can be confident that others will be doi

Re: class BuildTimeoutException extends BuildException

2010-10-27 Thread Stefan Bodewig
On 2010-10-27, Steve Loughran wrote: > On 27/10/10 11:01, Steve Loughran wrote: >> I'm thinking we need a specific class BuildTimeoutException that extends >> BuildException >> I'll do the coding... > Of course, there is a well documented exception of just that name in > org.apache.tools.ant.tas

Re: class BuildTimeoutException extends BuildException

2010-10-27 Thread Steve Loughran
On 27/10/10 11:01, Steve Loughran wrote: I'm thinking we need a specific class BuildTimeoutException that extends BuildException I'll do the coding... Of course, there is a well documented exception of just that name in org.apache.tools.ant.taskdefs.optional.testing Which implies that I shoul

class BuildTimeoutException extends BuildException

2010-10-27 Thread Steve Loughran
I'm thinking we need a specific class BuildTimeoutException that extends BuildException -Java.java looks for the specific error message "Timeout: killed the sub-process" in Exec.java to recognise a timeout, and doesn't even share the constant string across classes. -my own code looks for "Pa