Re: ant git commit: Unbreak tests

2018-07-09 Thread Stefan Bodewig
On 2018-07-07, Jaikiran Pai wrote: > Here's a status of the current state of upstream repo branches > "master" and "1.9.x". Many thanks, Jaikiran and many thanks for the detailed report. I've been able to reproduce the checks you've performed. I'll build RCs for the next Ant releases soon. Stef

Re: ant git commit: Unbreak tests

2018-07-09 Thread Stefan Bodewig
On 2018-07-06, wrote: > That would reduce the original "2f64e0b5"  diff to (the extra lines > starting with \ before the diff are added by the checker i wrote) Thanks, Martijn I've just committed the fix to Ant's URL inside jdepend.xsl. Stefan -

Re: ant git commit: Unbreak tests

2018-07-08 Thread Nicolas Lalevée
I have re done the revert and merge locally, and compared the diff between my local banches and the remote one. I had only diffs due to my editor automatically removing trailing space on empty lines, and I had to figure out what the status of the apt tasks (and indeed it doesn’t need to be merge

Re: ant git commit: Unbreak tests

2018-07-07 Thread Jaikiran Pai
Hello Martijn, Thank you for spending time on this and for that checker. I did look into yourmail and considered itbefore deciding on what to do with the state of upstream branches.I decided to go with a complete revert approach (which I explain in a separate reply in this thread), because I

Re: ant git commit: Unbreak tests

2018-07-07 Thread Jaikiran Pai
Here's a status of the current state of upstream repo branches "master" and "1.9.x". But before getting to it, I would like to state that I really had no pleasure in doing these reverts. I really do mean it. I wish we had never ended up in this situation (and hopefully will never again), but I

Re: ant git commit: Unbreak tests

2018-07-06 Thread jkf
Hello all Just for your info, please take into consideration for a rollback or not descision (I am neither happy with the commit, nor happy with a rollback and therefore am 0 on rollback or not): I have written a small checker to remove all whitespace only diffs from the diffs on the URL be

Re: ant git commit: Unbreak tests

2018-07-06 Thread Stefan Bodewig
On 2018-07-06, Jaikiran Pai wrote: > On 05/07/18 2:42 PM, Stefan Bodewig wrote: >> On 2018-07-05, Jaikiran Pai wrote: >>> I personally believe that reviewing these meaningless changes is a >>> waste of time and energy. I'm in favour of rolling back the entire >>> commit set if that's what it take

Re: ant git commit: Unbreak tests

2018-07-05 Thread Jaikiran Pai
On 05/07/18 2:42 PM, Stefan Bodewig wrote: On 2018-07-05, Jaikiran Pai wrote: I personally believe that reviewing these meaningless changes is a waste of time and energy. I'm in favour of rolling back the entire commit set if that's what it takes. +1 although reverting the commits in both b

Re: ant git commit: Unbreak tests

2018-07-05 Thread Stefan Bodewig
On 2018-07-05, Jaikiran Pai wrote: > I personally believe that reviewing these meaningless changes is a > waste of time and energy. I'm in favour of rolling back the entire > commit set if that's what it takes. +1 although reverting the commits in both branches and merging back the 1.9.x branch

Re: ant git commit: Unbreak tests

2018-07-04 Thread Jaikiran Pai
On 05/07/18 12:57 AM, Stefan Bodewig wrote: Gintas, - passfile="testpassfile.tmp"%/> + passfile="testpassfile.tmp"/> the commit that introduced the issue was labeled "Trailing whitespace" and I trusted to contain exactly that and didn't bother reviewing it. Obviously it did not. A s

Re: ant git commit: Unbreak tests

2018-07-04 Thread Stefan Bodewig
Gintas, > - passfile="testpassfile.tmp"%/> > + passfile="testpassfile.tmp"/> the commit that introduced the issue was labeled "Trailing whitespace" and I trusted to contain exactly that and didn't bother reviewing it. Obviously it did not. A single commit that spans a dozen mail messag