--- [EMAIL PROTECTED] wrote:
> bodewig 2005/03/17 06:23:58
>
> Modified:src/main/org/apache/tools/ant
> DirectoryScanner.java
> Log:
> DirectoryScanner improvements have been merged
I knew I forgot something... ;)
Thanks,
Matt
__
--- Dominique Devienne <[EMAIL PROTECTED]> wrote:
> > From: Matt Benson [mailto:[EMAIL PROTECTED]
> > --- Antoine Levy-Lambert <[EMAIL PROTECTED]> wrote:
[SNIP]
> > > Actually if an exclude pattern is like
> **/Test/**,
> > > every time a directory Test is encountered it
> should
> > > not be scan
> From: Matt Benson [mailto:[EMAIL PROTECTED]
> --- Antoine Levy-Lambert <[EMAIL PROTECTED]> wrote:
> > I had thought about this issue of optimizing pattern
> > scanning.
> > DirectoryScanner used to be written so that if an
> > exclude pattern looks like
> > foo/bar/** scanning stops in foo/bar.
>
--- Antoine Levy-Lambert <[EMAIL PROTECTED]> wrote:
> Hello Matt and others,
>
> I had thought about this issue of optimizing pattern
> scanning.
> DirectoryScanner used to be written so that if an
> exclude pattern looks like
> foo/bar/** scanning stops in foo/bar.
> Actually if an exclude patte
Hello Matt and others,
I had thought about this issue of optimizing pattern scanning.
DirectoryScanner used to be written so that if an exclude pattern looks like
foo/bar/** scanning stops in foo/bar.
Actually if an exclude pattern is like **/Test/**,
every time a directory Test is encountered it s
On Fri, 03 Dec 2004, Stefan Bodewig <[EMAIL PROTECTED]> wrote:
> I'll watch the next Gump run closely, both for breaking builds as
> well as performance impact.
No obvious breaks.
The run took 179 minutes, the previous one 184, but I don't think it
is related to my change (but rather to CVS and
On 3 Dec 2004, <[EMAIL PROTECTED]> wrote:
> Try to speed up DirectoryScanner by using hash lookups instead of
> linear searches and pattern matching on non-wildcard patterns.
I threatened to do it. I'll watch the next Gump run closely, both for
breaking builds as well as performance impact.
I had done a big mistake in my attempt to improve DirectoryScanner by not
scanning directories matching exclude patterns.
I realized this when I ran the ant test suite which took 1 minute instead of
the usual 5.
This is fixed now.
This routine to decide when exclude patterns are enough to stop scan
