Re: cvs commit: ant/src/main/org/apache/tools/ant ComponentHelper.java

2005-03-01 Thread Steve Loughran
[EMAIL PROTECTED] wrote: mbenson 2005/03/01 08:23:41 Modified:src/main/org/apache/tools/ant ComponentHelper.java Log: Some space/punctuation cleanup. Like it, Steve. I got fed up with seeing the message myself. Plus I even got a support phone call on the problem last week, which rea

Re: cvs commit: ant/src/main/org/apache/tools/ant ComponentHelper.java

2005-03-01 Thread Steve Loughran
Matt Benson wrote: //hey, there is nothing wrong with us -out.println("The component could be instantiated"); +out.println("The component could not be instantiated."); changes the meaning.. Sorry, didn't occur to me that a success messa

Re: cvs commit: ant/src/main/org/apache/tools/ant ComponentHelper.java

2005-03-01 Thread Matt Benson
--- Peter Reilly <[EMAIL PROTECTED]> wrote: > [EMAIL PROTECTED] wrote: > > >mbenson 2005/03/01 08:23:41 > > > > Modified:src/main/org/apache/tools/ant > ComponentHelper.java > > Log: > > Some space/punctuation cleanup. Like it, Steve. > > > > > > > snip > > >

Re: cvs commit: ant/src/main/org/apache/tools/ant ComponentHelper.java

2005-03-01 Thread Peter Reilly
[EMAIL PROTECTED] wrote: mbenson 2005/03/01 08:23:41 Modified:src/main/org/apache/tools/ant ComponentHelper.java Log: Some space/punctuation cleanup. Like it, Steve. snip //hey, there is nothing wrong with us -out.println("The component cou

Re: cvs commit: ant/src/main/org/apache/tools/ant ComponentHelper.java

2005-01-28 Thread Antoine Levy-Lambert
[EMAIL PROTECTED] wrote: mbenson 2005/01/28 08:01:07 Modified:src/main/org/apache/tools/ant ComponentHelper.java Log: Who'd have guessed that: boolean xor not boolean is equivalent to: boolean == boolean? Added a comment as well so Peter will be my friend again! I understand

Re: cvs commit: ant/src/main/org/apache/tools/ant ComponentHelper.java

2005-01-28 Thread Peter Reilly
Matt Benson wrote: --- Peter Reilly <[EMAIL PROTECTED]> wrote: Do we really need code that has to be read five times to figure out what it does? You cut me deep, Peter. Would you settle for a comment? ;) I did not mean to be too criticial, it can be fun to replace if else type code wi

Re: cvs commit: ant/src/main/org/apache/tools/ant ComponentHelper.java

2005-01-28 Thread Matt Benson
--- Peter Reilly <[EMAIL PROTECTED]> wrote: > Do we really need code that has to be read five > times > to figure out what it does? > You cut me deep, Peter. Would you settle for a comment? ;) -Matt > Peter > > [EMAIL PROTECTED] wrote: > > >mbenson 2005/01/27 13:53:27 > > > > Modified

Re: cvs commit: ant/src/main/org/apache/tools/ant ComponentHelper.java

2005-01-28 Thread Peter Reilly
Do we really need code that has to be read five times to figure out what it does? Peter [EMAIL PROTECTED] wrote: mbenson 2005/01/27 13:53:27 Modified:src/main/org/apache/tools/ant ComponentHelper.java Log: -2 characters Revision ChangesPath 1.47 +1 -1 ant/src/main/org/