Re: cvs commit: ant/src/main/org/apache/tools/ant/types ZipFileSet.java

2003-10-10 Thread Stefan Bodewig
On 10 Oct 2003, <[EMAIL PROTECTED]> wrote: > Fix PR 23639 This change fixes a regression (it worked in 1.4) where would not place the contents of the fileset into WEB-INF/lib but into the root of the archive. I've also change the filemode and dirmode attribute setters as well as the on

Re: cvs commit: ant/src/main/org/apache/tools/ant/types ZipFileSet.java

2003-04-23 Thread Stefan Bodewig
On Wed, 23 Apr 2003, Antoine Levy-Lambert <[EMAIL PROTECTED]> wrote: > Sorry for the trouble, No trouble, just observations 8-) Stefan

Re: cvs commit: ant/src/main/org/apache/tools/ant/types ZipFileSet.java

2003-04-23 Thread Antoine Levy-Lambert
Sorry for the trouble, I will fix it. Antoine - Original Message - From: "Stefan Bodewig" <[EMAIL PROTECTED]> To: <[EMAIL PROTECTED]> Sent: Wednesday, April 23, 2003 8:24 AM Subject: Re: cvs commit: ant/src/main/org/apache/tools/ant/types ZipFileSet.java >

Re: cvs commit: ant/src/main/org/apache/tools/ant/types ZipFileSet.java

2003-04-23 Thread Stefan Bodewig
On 22 Apr 2003, <[EMAIL PROTECTED]> wrote: > +if (o instanceof FileSet) { > + return (AbstractFileSet)(new ZipFileSet((FileSet)o)); the cast is not needed here. > +} > +else if (!(o instanceof ZipFileSet)) { will always be true as instanceof ZipFileSet

Re: cvs commit: ant/src/main/org/apache/tools/ant/types ZipFileSet.java defaults.properties

2003-04-22 Thread Stefan Bodewig
On Sat, 19 Apr 2003, Antoine Levy-Lambert <[EMAIL PROTECTED]> wrote: > I have coded the calls to the getters of ZipFileSet similarly to the > getters of FileSet or AbstractFileSet in Zip.java. They are the way they look right now because FileSet is much older than ProjectComponent and thus didn't

Re: cvs commit: ant/src/main/org/apache/tools/ant/types ZipFileSet.java defaults.properties

2003-04-19 Thread Antoine Levy-Lambert
getter to find the referred-to data in the case the FileSet is actually a reference ? Antoine - Original Message - From: "Conor MacNeill" <[EMAIL PROTECTED]> To: "Ant Developers List" <[EMAIL PROTECTED]> Sent: Saturday, April 19, 2003 1:34 AM Subject: Re: cvs

Re: cvs commit: ant/src/main/org/apache/tools/ant/types ZipFileSet.java defaults.properties

2003-04-18 Thread Conor MacNeill
On Sat, 19 Apr 2003 08:02 am, [EMAIL PROTECTED] wrote: > antoine 2003/04/18 15:02:59 > > Index: Zip.java > === > RCS file: /home/cvs/ant/src/main/org/apache/tools/ant/taskdefs/Zip.java,v > retrieving revision 1.103 > retr