Re: cvs commit: ant/src/main/org/apache/tools/ant/taskdefs Copy.java DependSet.java

2005-01-04 Thread Martijn Kruithof
Hi Unless anyone objects within the next few days I will apply a patch that will make use of getFileUtils instead of newFileUtils in all files in a uniform way (122 files impacted). I have manually checked if it could do any harm when using the same instance of the FileUtils everywhere and could

Re: cvs commit: ant/src/main/org/apache/tools/ant/taskdefs Copy.java

2004-09-01 Thread Matt Benson
Thanks Jan, I was afraid I was forgetting something. :( -Matt --- [EMAIL PROTECTED] wrote: > jhm 2004/08/31 22:38:54 > > Modified: > src/main/org/apache/tools/ant/taskdefs Copy.java > Log: > Let compile. > > Revision ChangesPath > 1.73 +2 -3 > ant/src/m

Re: cvs commit: ant/src/main/org/apache/tools/ant/taskdefs Copy.java

2004-09-01 Thread Antoine Levy-Lambert
Hello Jan, I thought we wanted to have fields always private. This is what checkstyle checks. Cheers, Antoine > jhm 2004/09/01 00:02:23 > > Modified:src/main/org/apache/tools/ant/taskdefs Tag: ANT_16_BRANCH > Copy.java > Log: > Let compile. > > Revi

Re: cvs commit: ant/src/main/org/apache/tools/ant/taskdefs Copy.java Move.java

2003-05-19 Thread Stefan Bodewig
On 19 May 2003, <[EMAIL PROTECTED]> wrote: > Don't remove basedirectories of s that just happen to be > matched completely. This introduces a backwards incompatibility and maybe even inconsistency, that's why I haven't closed the bug report yet. I'm asking for feedback here. The bug report

Re: cvs commit: ant/src/main/org/apache/tools/ant/taskdefs Copy.java

2003-03-28 Thread Stefan Bodewig
On 28 Mar 2003, <[EMAIL PROTECTED]> wrote: > - public void setFailOnError(boolean failonerror) { > - this.failonerror = failonerror; > - } > +public void setFailOnError(boolean failonerror) { > +this.failonerror = failonerror; > +} I have no idea wha