Re: cvs commit: ant/src/main/org/apache/tools/ant/taskdefs Checksum.java

2005-01-06 Thread Peter Reilly
Most of these are setX(x) where x is already defined in the javadoc. So there is no point in repeating the definition. (see the javadoc for most of the jdk). The buildexception statement is a bit meaningless, but it does capture what will happen. Peter Martijn Kruithof wrote: I understand the impor

Re: cvs commit: ant/src/main/org/apache/tools/ant/taskdefs Checksum.java

2005-01-06 Thread Martijn Kruithof
I understand the importance of improving the style, but shouldn't we prefer no comments (warnings stay to indicate they are missing) over this kind of comments: Kind Regards, Martijn + * @param file a File value + * @param algorithm a String value + * @param provider a String value