Re: cvs commit: ant/src/main/org/apache/tools/ant/taskdefs Ant.java

2005-08-08 Thread Matt Benson
I'm so ashamed. :) -Matt --- [EMAIL PROTECTED] wrote: > peterreilly2005/08/08 02:02:55 > > Modified: > src/main/org/apache/tools/ant/taskdefs Ant.java > Log: > Replace x == "" with "".equals(x) to check if we > are > looking at the empty target > Obtained from: Alexey Panchenko

Re: cvs commit: ant/src/main/org/apache/tools/ant/taskdefs Ant.java CallTarget.java

2004-12-15 Thread Matt Benson
--- Matt Benson <[EMAIL PROTECTED]> wrote: > I rarely document overridden methods myself, but I > will admit that I may have accidentally deleted > information detailing how the subclass > implementation > differs or elaborates substantially upon the base > implementation. I will go back today a

Re: cvs commit: ant/src/main/org/apache/tools/ant/taskdefs Ant.java CallTarget.java

2004-12-15 Thread Matt Benson
I rarely document overridden methods myself, but I will admit that I may have accidentally deleted information detailing how the subclass implementation differs or elaborates substantially upon the base implementation. I will go back today and take a second look at what I deleted. --- Peter Rei

Re: cvs commit: ant/src/main/org/apache/tools/ant/taskdefs Ant.java CallTarget.java

2004-12-15 Thread Peter Reilly
Hi Matt, the following changes remove information from the javadoc. Peter [EMAIL PROTECTED] wrote: mbenson 2004/12/14 13:18:08 Modified:src/main/org/apache/tools/ant/taskdefs Ant.java CallTarget.java Log: Javadoc Revision ChangesPath 1.110 +31 -50a

Re: cvs commit: ant/src/main/org/apache/tools/ant/taskdefs Ant.java

2003-10-10 Thread peter reilly
Opps, Well found! Peter On Friday 10 October 2003 14:19, [EMAIL PROTECTED] wrote: > bodewig 2003/10/10 06:19:46 > @@ -450,10 +450,12 @@ >Set set = new HashSet(); >for (int i = properties.size() - 1; i >= 0; --i) { >Property p = (Property) properties.ge

Re: cvs commit: ant/src/main/org/apache/tools/ant/taskdefs Ant.java

2003-09-17 Thread Steve Loughran
Conor MacNeill wrote: On Sat, 13 Sep 2003 12:04 am, [EMAIL PROTECTED] wrote: conor 2003/09/12 07:04:46 Modified:src/main/org/apache/tools/ant/taskdefs Ant.java Log: Mark entry and exit of and PR:22718 Submitted by: Jesse Glick This gives a message on entry and exit to a sub-b

Re: cvs commit: ant/src/main/org/apache/tools/ant/taskdefs Ant.java

2003-09-12 Thread Stefan Bodewig
On Sat, 13 Sep 2003, Conor MacNeill <[EMAIL PROTECTED]> wrote: > The question I have is whether to log at INFO or VERBOSE level. I'd say VERBOSE. Stefan - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mai

Re: cvs commit: ant/src/main/org/apache/tools/ant/taskdefs Ant.java

2003-09-12 Thread Conor MacNeill
On Sat, 13 Sep 2003 12:04 am, [EMAIL PROTECTED] wrote: > conor 2003/09/12 07:04:46 > > Modified:src/main/org/apache/tools/ant/taskdefs Ant.java > Log: > Mark entry and exit of and > > PR: 22718 > Submitted by: Jesse Glick > This gives a message on entry and exit to a su

Re: cvs commit: ant/src/main/org/apache/tools/ant/taskdefs Ant.java

2003-09-10 Thread Stefan Bodewig
On Wed, 10 Sep 2003, peter reilly <[EMAIL PROTECTED]> wrote: > The solution is not to execute the target if > the target is "". I agree. Stefan - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL

Re: cvs commit: ant/src/main/org/apache/tools/ant/taskdefs Ant.java

2003-09-10 Thread peter reilly
This reminds me of another bug I forgot to report. If is called without setting target, the default target is called. If there is no default target, the "" target is called. This means that the top-level tasks are called twice. Example: hello.xml Hello world build.xml ... The solutio