Re: ant git commit: Remove redundancies

2018-08-26 Thread Gintautas Grigelionis
On Thu, 23 Aug 2018 at 07:06, Stefan Bodewig wrote: > On 2018-08-22, Matt Sicker wrote: > > > Pretty much every implementation of javac will automatically convert the > > string concatenation code into StringBuilders. Decompile the byte code > and > > see for yourself. > > I know that :-) > > The

Re: ant git commit: Remove redundancies

2018-08-22 Thread Stefan Bodewig
On 2018-08-22, Matt Sicker wrote: > Pretty much every implementation of javac will automatically convert the > string concatenation code into StringBuilders. Decompile the byte code and > see for yourself. I know that :-) The thing I qibble about is the commit message says "remove redundancies"

Re: ant git commit: Remove redundancies

2018-08-22 Thread Matt Sicker
Pretty much every implementation of javac will automatically convert the string concatenation code into StringBuilders. Decompile the byte code and see for yourself. On Tue, 21 Aug 2018 at 13:05, Stefan Bodewig wrote: > > > diff --git a/src/main/org/apache/tools/ant/types/PatternSet.java > b/src

Re: ant git commit: Remove redundancies

2018-08-21 Thread Stefan Bodewig
> diff --git a/src/main/org/apache/tools/ant/types/PatternSet.java > b/src/main/org/apache/tools/ant/types/PatternSet.java > -: new > StringBuilder(baseString).append(";encoding->").append(encoding).toString(); > +: baseString + ";encoding->" + encoding; I don'