On Mon, 29 Oct 2018 at 10:00, Stefan Bodewig wrote:
> There is no cycle: core <- testutil <- tests of core
>
> It is just Maven's model that doesn't allow you to introduce test scope
> dependencies that depend on your code under test. A model I disagree
> with.
>
> So in the maven POMs we might b
On 2018-10-28, Gintautas Grigelionis wrote:
> Even if running unit tests with different tools is a no-goal for you, it's
> a good check of robustness --
ACK
> I'm afraid we're cheating a little anyway by compiling testutil with core
> tests first, and then building a separate jar file.
This is
On 2018-10-29, Gintautas Grigelionis wrote:
>> Thanks, I'll merge it to master, then.
> I've notice in Nightly that Ant treats MagicTestNames as a test, too.
Uhm, it shouldn't.
> Would it make sense to add a test method, checking for documented
> properties?
Adding a test that asserts the cons
> Thanks, I'll merge it to master, then.
>
I've notice in Nightly that Ant treats MagicTestNames as a test, too.
Would it make sense to add a test method, checking for documented
properties?
Gintas
On 2018-10-28, Gintautas Grigelionis wrote:
>> The tests for core fail for me (CommandlineJava) anyway. I think I've
>> already said that running Ant's unit tests in Maven is a non-goal for me
>> :-)
> I'll have a closer look at it tomorrow, if you don't mind. Could you please
> provide some deta
> The tests for core fail for me (CommandlineJava) anyway. I think I've
> already said that running Ant's unit tests in Maven is a non-goal for me
> :-)
>
I'll have a closer look at it tomorrow, if you don't mind. Could you please
provide some details of your setup?
Even if running unit tests with
On 2018-10-28, Gintautas Grigelionis wrote:
> On Sun, 28 Oct 2018 at 21:02, Stefan Bodewig wrote:
>> On 2018-10-28, Gintautas Grigelionis wrote:
>>> On Sun, 28 Oct 2018 at 20:23, Stefan Bodewig wrote:
I guess I need to create a branch to either convince you it is possible
or convince
On Sun, 28 Oct 2018 at 21:02, Stefan Bodewig wrote:
> On 2018-10-28, Gintautas Grigelionis wrote:
> > On Sun, 28 Oct 2018 at 20:23, Stefan Bodewig wrote:
>
> >> I guess I need to create a branch to either convince you it is possible
> >> or convince me that it is not :-)
>
> > No branch is neces
On 2018-10-28, Gintautas Grigelionis wrote:
> On Sun, 28 Oct 2018 at 20:23, Stefan Bodewig wrote:
>> I guess I need to create a branch to either convince you it is possible
>> or convince me that it is not :-)
> No branch is necessary, just activate launcher tests; the effect will be
> the sam
On Sun, 28 Oct 2018 at 20:23, Stefan Bodewig wrote:
> On 2018-10-28, Gintautas Grigelionis wrote:
> > On Sun, 28 Oct 2018 at 18:48, Stefan Bodewig wrote:
> >> On 2018-10-28, Gintautas Grigelionis wrote:
> >>> On Sun, 28 Oct 2018 at 18:17, Stefan Bodewig
> wrote:
> On 2018-10-28, Gintautas
On 2018-10-28, Stefan Bodewig wrote:
> On 2018-10-28, Gintautas Grigelionis wrote:
>> On Sun, 28 Oct 2018 at 18:48, Stefan Bodewig wrote:
>>> On 2018-10-28, Gintautas Grigelionis wrote:
On Sun, 28 Oct 2018 at 18:17, Stefan Bodewig wrote:
> On 2018-10-28, Gintautas Grigelionis wrote:
>
On 2018-10-28, Gintautas Grigelionis wrote:
> On Sun, 28 Oct 2018 at 18:48, Stefan Bodewig wrote:
>> On 2018-10-28, Gintautas Grigelionis wrote:
>>> On Sun, 28 Oct 2018 at 18:17, Stefan Bodewig wrote:
On 2018-10-28, Gintautas Grigelionis wrote:
> On Sun, 28 Oct 2018 at 17:59, Stefan Bo
On Sun, 28 Oct 2018 at 18:48, Stefan Bodewig wrote:
> On 2018-10-28, Gintautas Grigelionis wrote:
> > On Sun, 28 Oct 2018 at 18:17, Stefan Bodewig wrote:
> >> On 2018-10-28, Gintautas Grigelionis wrote:
> >>> On Sun, 28 Oct 2018 at 17:59, Stefan Bodewig
> wrote:
>
> I wonder whether it wou
On 2018-10-28, Gintautas Grigelionis wrote:
> On Sun, 28 Oct 2018 at 18:17, Stefan Bodewig wrote:
>> On 2018-10-28, Gintautas Grigelionis wrote:
>>> On Sun, 28 Oct 2018 at 17:59, Stefan Bodewig wrote:
I wonder whether it wouldn't be a good idea to create a separate class
for constant
On Sun, 28 Oct 2018 at 18:17, Stefan Bodewig wrote:
> On 2018-10-28, Gintautas Grigelionis wrote:
> > On Sun, 28 Oct 2018 at 17:59, Stefan Bodewig wrote:
>
> >> I wonder whether it wouldn't be a good idea to create a separate class
> >> for constants used during testing that lives in ant-testuti
On 2018-10-28, Gintautas Grigelionis wrote:
> On Sun, 28 Oct 2018 at 17:59, Stefan Bodewig wrote:
>> I wonder whether it wouldn't be a good idea to create a separate class
>> for constants used during testing that lives in ant-testutil rather than
>> poluting the "magic names" of Ant.
> The pro
On Sun, 28 Oct 2018 at 17:59, Stefan Bodewig wrote:
> On 2018-10-23, wrote:
>
> >
> http://git-wip-us.apache.org/repos/asf/ant/blob/679a9422/src/main/org/apache/tools/ant/MagicNames.java
>
> >+/**
> >+ * Magic property that makes unit tests based on BuildFileTest
> >+ * or BuildFileR
On 2018-10-23, wrote:
> http://git-wip-us.apache.org/repos/asf/ant/blob/679a9422/src/main/org/apache/tools/ant/MagicNames.java
>+/**
>+ * Magic property that makes unit tests based on BuildFileTest
>+ * or BuildFileRule ignore externally set basedir
>+ * (typically by Surefire/Fa
18 matches
Mail list logo
