Re: Out of memory errors since recent changes.

2005-01-14 Thread Peter Reilly
Ok, I have seen the problem on my machine (after removing export ANT_OPTS="-Xms200m -Xmx1000m" from my .bashrc file). I tryed to make a solution that required less memory but it did not work. So I pulled the local property impl (for the moment). Jose's solution is possibly the way to go at the mome

Re: Out of memory errors since recent changes.

2005-01-14 Thread Matt Benson
--- Peter Reilly <[EMAIL PROTECTED]> wrote: > Is this a specific test, or is it all the tests? > > Peter Peter, it's when running the full suite; it's an accumulation problem. Mine usually dies around oata.taskdefs.F* , usually FixCRLFTest but sometimes FilterTest, and Martijn also mentioned E

Re: Out of memory errors since recent changes.

2005-01-14 Thread Peter Reilly
Martijn Kruithof wrote: I can see from traces I added to the code that thousands of LocalPropertyStacks are created via the |InheritableThreadLocal|, hundreds of them seem to be never cleaned up, at the same time the number of threads remains more or less constant. When rolling back the last two

Re: Out of memory errors since recent changes.

2005-01-14 Thread Alexey N. Solofnenko
Implementation seems strange. Usually thread local objects are used as following: private static ThreadLocal threadLocalProperties=new InheritableThreadLocal(); // notice "static" there public static ThreadLocalProperties getLocalProperties() { // static too ThreadLocalProperties properties=(

Re: Out of memory errors since recent changes.

2005-01-13 Thread Matt Benson
You said they are created via the ITL get()? So does it look like there are lots of Threads but when they did their ITLs instances aren't getting cleaned up? Or does it rather look like we are creating more LocalPropertyStacks than necessary? -Matt --- Martijn Kruithof <[EMAIL PROTECTED]> wrote:

Re: Out of memory errors since recent changes.

2005-01-13 Thread Martijn Kruithof
I can see from traces I added to the code that thousands of LocalPropertyStacks are created via the |InheritableThreadLocal|, hundreds of them seem to be never cleaned up, at the same time the number of threads remains more or less constant. When rolling back the last two commits (local propertie

Re: Out of memory errors since recent changes.

2005-01-13 Thread Matt Benson
I usually update at least every morning, and I was running ant test yesterday evening... 20 hours ago, without this. I would put the offending change sometime within the last 28 hours... also, it looks like an accumulation, rather than a problem with a specific test. The most widely applicable co