Re: SSHSession design (was: Re: First-time contributor - advice needed)

2007-08-09 Thread Dominique Devienne
> >An alternative in line with your proposed extension is to move the > >inheritance away from and into and > > > > I'm not keen on this. It restricts you to having only one tunnel at a > time. I think I'd like to establish all tunnels up front, then any of > the nested tasks can use any of the

Re: SSHSession design (was: Re: First-time contributor - advice needed)

2007-08-09 Thread DJohnson
Dominique Devienne wrote: >On 8/9/07, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote: >> Steve Loughran said: >> >2. I'd put the nested commands into a , the way we did in >> >. This makes it clear it is sequential, and it leaves room to >> >add new things alongside . > >> I'd like to discuss further

Re: SSHSession design (was: Re: First-time contributor - advice needed)

2007-08-09 Thread Dominique Devienne
On 8/9/07, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote: > Steve Loughran said: > >2. I'd put the nested commands into a , the way we did in > >. This makes it clear it is sequential, and it leaves room to > >add new things alongside . > I'd like to discuss further your suggestion of incorporating

SSHSession design (was: Re: First-time contributor - advice needed)

2007-08-09 Thread DJohnson
Steve Loughran said: >>> What is your new task trying to do? >> >> It is sshsession, a container task which establishes an SSH connection, >> and optionally any number of local or remote tunnels over that connection, >> then executes any nested tasks before taking down the connection. >> >> My pur

Re: First-time contributor - advice needed

2007-08-09 Thread Steve Loughran
[EMAIL PROTECTED] wrote: Steve Loughran said: I have a new task to contribute under optional/ssh, but when I do an "ant -f patch.xml" I get a lot of other files in the patch.tar.gz. I'm thinking it should only have my new class source and the patch to default.properties. Am I correct, and sh

Re: First-time contributor - advice needed

2007-08-08 Thread DJohnson
Steve Loughran said: >> I have a new task to contribute under optional/ssh, but when I do an "ant >> -f patch.xml" I get a lot of other files in the patch.tar.gz. I'm >> thinking it should only have my new class source and the patch to >> default.properties. Am I correct, and should I just manua

Re: First-time contributor - advice needed

2007-08-08 Thread Peter Reilly
I would not use the patch.xml file. I would use svn add for the new files. and then svn status to show the files modied and added and not under source code control. (the ? character). svn diff will now produce a patch file containing the changes and the new files. Peter On 8/8/07, Steve Loughr

Re: First-time contributor - advice needed

2007-08-08 Thread Steve Loughran
[EMAIL PROTECTED] wrote: I have a new task to contribute under optional/ssh, but when I do an "ant -f patch.xml" I get a lot of other files in the patch.tar.gz. I'm thinking it should only have my new class source and the patch to default.properties. Am I correct, and should I just manually r