Re: BZ 48768: Properties wrongly read from file or not update during read

2010-02-24 Thread Peter Reilly
Great news. Peter On Wed, Feb 24, 2010 at 4:22 PM, Stefan Bodewig wrote: > On 2010-02-24, Stefan Bodewig wrote: > >> To account for the bug report it may be a good idea to ignore existing >> properties only if we are importing with a prefix. > > and look for an existing property with the prefix

Re: BZ 48768: Properties wrongly read from file or not update during read

2010-02-24 Thread Stefan Bodewig
On 2010-02-24, Stefan Bodewig wrote: > To account for the bug report it may be a good idea to ignore existing > properties only if we are importing with a prefix. and look for an existing property with the prefix when using one. I have a modified version that passes the testcase I've added for

Re: BZ 48768: Properties wrongly read from file or not update during read

2010-02-24 Thread Peter Reilly
I think that we will just have to put the old code (1.7) back in. Peter On Wed, Feb 24, 2010 at 4:10 PM, Stefan Bodewig wrote: > On 2010-02-18, Matt Benson wrote: > >> This problem happens in src/main/org/apache/tools/ant/property/ >> ResolvePropertyMap.java .  Peter, you extracted this class s

Re: BZ 48768: Properties wrongly read from file or not update during read

2010-02-24 Thread Stefan Bodewig
On 2010-02-18, Matt Benson wrote: > This problem happens in src/main/org/apache/tools/ant/property/ > ResolvePropertyMap.java . Peter, you extracted this class some two > years ago, but at the point in the code at which the offense takes > place, there is the comment: > // Note: the mas

Re: BZ 48768: Properties wrongly read from file or not update during read

2010-02-22 Thread Matt Benson
Thanks for looking into this one, Peter. -Matt On Feb 22, 2010, at 9:24 AM, Peter Reilly wrote: I think that I was trying to allow the map to be used in a stack of property maps. But looking at the original code for Property in 1.7, I got it wrong, so I have removed the test. Peter On Fri,

Re: BZ 48768: Properties wrongly read from file or not update during read

2010-02-22 Thread Peter Reilly
I think that I was trying to allow the map to be used in a stack of property maps. But looking at the original code for Property in 1.7, I got it wrong, so I have removed the test. Peter On Fri, Feb 19, 2010 at 2:57 PM, Peter Reilly wrote: > Looks like a bad bug. > > Will have a look during the

Re: BZ 48768: Properties wrongly read from file or not update during read

2010-02-19 Thread Peter Reilly
Looks like a bad bug. Will have a look during the weekend. Peter On Thu, Feb 18, 2010 at 8:33 PM, Antoine Levy-Lambert wrote: > Hello Matt, > >> Datum: Thu, 18 Feb 2010 12:27:26 -0600 >> Von: Matt Benson >> An: Ant Developers List > >> Convenience link: >> https://issues.apache.org/bugzilla/

Re: BZ 48768: Properties wrongly read from file or not update during read

2010-02-18 Thread Antoine Levy-Lambert
Hello Matt, > Datum: Thu, 18 Feb 2010 12:27:26 -0600 > Von: Matt Benson > An: Ant Developers List > Convenience link: > https://issues.apache.org/bugzilla/show_bug.cgi?id=48768 > > The behavior reported in BZ > does seem counter-intuitive and wrong. Agreed. > Thanks, > Matt > Antoine