Re: [patch] mainly name-hiding

2005-03-14 Thread Conor MacNeill
Kev, It seems that the most of my (small) contributions of last week were in vain, c'est la vie. Sorry for wasting time people. Not at all. I think even if it just triggers a discussion, it's worthwhile. I've never been overly into worrying about compiler warnings since some compilers try too

Re: [patch] mainly name-hiding

2005-03-14 Thread Kev Jackson
Martijn Kruithof wrote: Conor MacNeill wrote: Likewise, I do not see converting an if-else to a ternary conditional makes the code clearer - on the contrary it makes it more convoluted. Sorry about this one (the ternary conditional). I very rarely use these, and in this case, I was getting "un

Re: [patch] mainly name-hiding

2005-03-11 Thread Martijn Kruithof
Conor MacNeill wrote: Likewise, I do not see converting an if-else to a ternary conditional makes the code clearer - on the contrary it makes it more convoluted. Ternary conditionals are one of my favorite things. I riddle the code with them in the interest of making it smaller... surely it doe

Re: [patch] mainly name-hiding

2005-03-11 Thread Conor MacNeill
I believe these are responses to Jikes' complaining about shadowed instance variables. No doubt - I'm not sure that Jikes should dictate the code. Likewise, I do not see converting an if-else to a ternary conditional makes the code clearer - on the contrary it makes it more convoluted. Ternary c

Re: [patch] mainly name-hiding

2005-03-11 Thread Matt Benson
--- Conor MacNeill <[EMAIL PROTECTED]> wrote: > Kevin, > > I had a quick look at thi spatch and not sure I > agree with some thigns > in it. > > I'm not sure I understand the motivation for this > name hiding stuff. > Changing variable names from "password" to "pass" or > "daemonTasks" to > "d

Re: [patch] mainly name-hiding

2005-03-10 Thread Conor MacNeill
Kevin, I had a quick look at thi spatch and not sure I agree with some thigns in it. I'm not sure I understand the motivation for this name hiding stuff. Changing variable names from "password" to "pass" or "daemonTasks" to "dTasks" does not strike me as being an improvement. Likewise, I do no