Re: [32/34] ant git commit: java 5-8

2017-04-21 Thread Stefan Bodewig
On 2017-04-20, Matt Benson wrote: > On Thu, Apr 20, 2017 at 2:48 AM, Stefan Bodewig wrote: >> Wouldn't we end up with a null InputStream and an exception being thrown >> later on? > In my debugging the XML parser allowed the null InputStream and took it > upon itself to go find the named resour

Re: [32/34] ant git commit: java 5-8

2017-04-20 Thread Matt Benson
On Thu, Apr 20, 2017 at 2:48 AM, Stefan Bodewig wrote: > On 2017-04-19, Matt Benson wrote: > > > I had forgotten about this. When testing my other changes I noted that no > > InputStream was returned here, due to the requested entry name including > > the leading slash from the jar resource URL;

Re: [32/34] ant git commit: java 5-8

2017-04-20 Thread Stefan Bodewig
On 2017-04-19, Matt Benson wrote: > I had forgotten about this. When testing my other changes I noted that no > InputStream was returned here, due to the requested entry name including > the leading slash from the jar resource URL; the jar entries encountered > during testing, at least, lacked the

Re: [32/34] ant git commit: java 5-8

2017-04-19 Thread Matt Benson
Hi Stefan, I had forgotten about this. When testing my other changes I noted that no InputStream was returned here, due to the requested entry name including the leading slash from the jar resource URL; the jar entries encountered during testing, at least, lacked the leading slash. Due to this th

Re: [32/34] ant git commit: java 5-8

2017-04-19 Thread Stefan Bodewig
Matt, something I overlooked on my first pass On 2017-04-13, wrote: > http://git-wip-us.apache.org/repos/asf/ant/blob/b7d1e9bd/src/main/org/apache/tools/ant/helper/ProjectHelper2.java > @@ -256,7 +259,7 @@ public class ProjectHelper2 extends ProjectHelper { > zf = new ZipFi