Re: [2/2] ant git commit: Bz 22370: followlinks attribute

2018-06-19 Thread Gintautas Grigelionis
More symlinks related issues (see [5] ... below) Gintas On Wed, 6 Jun 2018 at 21:30, Gintautas Grigelionis wrote: > > There are other issues, like support for symlinks in archives (JRE does > not support them in > zip files [1], rather one -- like Gradle [2] -- must use Commons > Compress). Act

Re: [2/2] ant git commit: Bz 22370: followlinks attribute

2018-06-16 Thread Gintautas Grigelionis
Den lör 16 juni 2018 kl 17:29 skrev Stefan Bodewig : > On 2018-06-16, Gintautas Grigelionis wrote: > > > 2018-06-16 15:42 GMT+02:00 Stefan Bodewig : > > >> On 2018-06-06, Gintautas Grigelionis wrote: > > >>> 2018-06-06 14:31 GMT+02:00 Stefan Bodewig : > > Would the symlink be included in Dire

Re: [2/2] ant git commit: Bz 22370: followlinks attribute

2018-06-16 Thread Stefan Bodewig
On 2018-06-16, Gintautas Grigelionis wrote: > 2018-06-16 15:42 GMT+02:00 Stefan Bodewig : >> On 2018-06-06, Gintautas Grigelionis wrote: >>> 2018-06-06 14:31 GMT+02:00 Stefan Bodewig : I guess here our API breaks down as we only ever deal with files or directories (outside of the syml

Re: [2/2] ant git commit: Bz 22370: followlinks attribute

2018-06-16 Thread Gintautas Grigelionis
2018-06-16 15:42 GMT+02:00 Stefan Bodewig : > On 2018-06-06, Gintautas Grigelionis wrote: > > > 2018-06-06 14:31 GMT+02:00 Stefan Bodewig : > > >> I guess here our API breaks down as we only ever deal with files or > >> directories (outside of the symlink task). > > > FileSet documentation should

Re: [2/2] ant git commit: Bz 22370: followlinks attribute

2018-06-16 Thread Stefan Bodewig
On 2018-06-06, Gintautas Grigelionis wrote: > 2018-06-06 14:31 GMT+02:00 Stefan Bodewig : >> I guess here our API breaks down as we only ever deal with files or >> directories (outside of the symlink task). > FileSet documentation should be more explicit about the matter, in > particular explain

Re: [2/2] ant git commit: Bz 22370: followlinks attribute

2018-06-06 Thread Gintautas Grigelionis
2018-06-06 14:31 GMT+02:00 Stefan Bodewig : > I guess here our API breaks down as we only ever deal with files or > directories (outside of the symlink task). > FileSet documentation should be more explicit about the matter, in particular explaining what "followsymlinks" really means. Would the

Re: [2/2] ant git commit: Bz 22370: followlinks attribute

2018-06-06 Thread Stefan Bodewig
On 2018-06-06, Gintautas Grigelionis wrote: > 2018-06-06 10:50 GMT+02:00 Stefan Bodewig : >> On 2018-06-05, Gintautas Grigelionis wrote: >>> Stefan is right -- "followsymlinks" for the fileset should have been >> called >>> "skipsymlinks" or something like that. >> I'm afraid I don't follow you

Re: [2/2] ant git commit: Bz 22370: followlinks attribute

2018-06-06 Thread Gintautas Grigelionis
2018-06-06 10:50 GMT+02:00 Stefan Bodewig : > On 2018-06-05, Gintautas Grigelionis wrote: > > > Stefan is right -- "followsymlinks" for the fileset should have been > called > > "skipsymlinks" or something like that. > > I'm afraid I don't follow you here, what did you expect followsymlinks > goin

Re: [2/2] ant git commit: Bz 22370: followlinks attribute

2018-06-06 Thread Stefan Bodewig
On 2018-06-05, Gintautas Grigelionis wrote: > Stefan is right -- "followsymlinks" for the fileset should have been called > "skipsymlinks" or something like that. I'm afraid I don't follow you here, what did you expect followsymlinks going by the name? What would the "new semantics of followsymli

Re: [2/2] ant git commit: Bz 22370: followlinks attribute

2018-06-04 Thread Gintautas Grigelionis
2018-06-04 8:26 GMT+02:00 Stefan Bodewig : > What happens when I do something like this > > > > > > I believe - but haven't tested it - that for symlinks is never > going to be invoked at all as DirectoryScanner will skip the symlink so > the attribute's value on ownedby is irrelevant. If I'

Re: [2/2] ant git commit: Bz 22370: followlinks attribute

2018-06-04 Thread Gintautas Grigelionis
2018-06-04 8:26 GMT+02:00 Stefan Bodewig : > What happens when I do something like this > > > > > > I believe - but haven't tested it - that for symlinks is never > going to be invoked at all as DirectoryScanner will skip the symlink so > the attribute's value on ownedby is irrelevant. If I'

Re: [2/2] ant git commit: Bz 22370: followlinks attribute

2018-06-03 Thread Stefan Bodewig
On 2018-06-01, Gintautas Grigelionis wrote: > thanks for reviewing this. I missed the fact that filesets had a similar > attribute. > Hope everything is consistent now. What I meant with >> you should probably check and document how the new followlinks attribute >> interacts with fileset's follo

Re: [2/2] ant git commit: Bz 22370: followlinks attribute

2018-06-01 Thread Gintautas Grigelionis
Hi Stefan, thanks for reviewing this. I missed the fact that filesets had a similar attribute. Hope everything is consistent now. Gintas 2018-05-28 17:00 GMT+02:00 Stefan Bodewig : > Hi Gintas > > you should probably check and document how the new followlinks attribute > interacts with fileset'

Re: [2/2] ant git commit: Bz 22370: followlinks attribute

2018-05-28 Thread Stefan Bodewig
Hi Gintas you should probably check and document how the new followlinks attribute interacts with fileset's followsymlinks attribute. Please add something to WHATSNEW. Some additional notes inline. On 2018-05-23, wrote: > http://git-wip-us.apache.org/repos/asf/ant/blob/35a84fea/manual/Types/s