> > Because we have a 1.6 version and a head version on cvs. How should
> > I commit the changes?
>
> Twice.
>
> The easiest way for you probably is to copy your ant workspace and
> inside your copy run cvs up -r ANT_16_BRANCH. After that the copy
> will be working on the branch while your old c
> > Because we have a 1.6 version and a head version on cvs. How should
> > I commit the changes?
>
> On both versions.
> The easiest is to make the changes on HEAD, make a diff file (before
> the commit on HEAD), and apply the changes to 1.6, and then commit
> in both.
- changes on HEAD: ok, tha
On Tue, 23 Sep 2003, Jan Materne <[EMAIL PROTECTED]> wrote:
> Because we have a 1.6 version and a head version on cvs. How should
> I commit the changes?
Twice.
The easiest way for you probably is to copy your ant workspace and
inside your copy run cvs up -r ANT_16_BRANCH. After that the copy
w
tember 23, 2003 3:24 PM
> > To: [EMAIL PROTECTED]
> > Subject: Re: concat teardown failing
> >
> > On Tue, 23 Sep 2003, Jan Materne <[EMAIL PROTECTED]> wrote:
> > > I have modified the FileUtils.readFully(Reader rdr, int bufferSize)
> > > so that it clo
tember 23, 2003 3:24 PM
> To: [EMAIL PROTECTED]
> Subject: Re: concat teardown failing
>
>
> On Tue, 23 Sep 2003, Jan Materne <[EMAIL PROTECTED]> wrote:
>
> > I have modified the FileUtils.readFully(Reader rdr, int bufferSize)
> > so that it closes the reader
On Tue, 23 Sep 2003, Jan Materne <[EMAIL PROTECTED]> wrote:
> I have modified the FileUtils.readFully(Reader rdr, int bufferSize)
> so that it closes the reader and all works.
I think that would be the wrong place. It may be my old C thinking
coming from explicit memory managment, but I think th
in the ConcatFilterTest.
Yes, only the org.apache.tools.ant.taskdefs.ReplaceTest.test9() fails (like
before).
Thanks Peter.
Jan
> -Original Message-
> From: peter reilly [mailto:[EMAIL PROTECTED]
> Sent: Tuesday, September 23, 2003 2:35 PM
> To: Ant Developers List
> Subj
Bingo, I think.
The tests in ConcatFilterTest do this:
String resultContent = fu.readFully(
new java.io.FileReader(resultFile));
so nothing closes the resultfile.
Peter
On Tuesday 23 September 2003 10:17, [EMAIL PROTECTED] wrote:
> co
>
> > > ncat.filterReaderPrepend.tes
-
nal Message-
> From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED]
> Sent: Tuesday, September 23, 2003 12:50 PM
> To: [EMAIL PROTECTED]
> Subject: RE: concat teardown failing
>
>
> Difference to my solution is only that you´re setting the append- and
> prepend read
Difference to my solution is only that you´re setting the append- and
prepend reader
to null. But that don´t work on my machine :-(
But I don´t get the error while deleting the append- or prepend file. I get
the error
while deleting the resulting file.
But if I add a "super.close()" I´ll get othe
On Tuesday 23 September 2003 11:10, [EMAIL PROTECTED] wrote:
> I have tried with closing them, but it doesn´t work.
> But send me your code please. Maybe you have done some different :-)
>
>
Attached.
PeterIndex: ConcatFilter.java
===
lete file
> >
> C:\seu\cvs-downloads\ant\ant\src\etc\testcases\filters\result\
> concat.filter
> >R eaderPrepend.test
> >
> >
> > The concat.filterReaderPrepend.test can´t be deleted but
> it´s closed in
> > line 669.
> >
> > Any ideas?
&g
y ideas?
>
>
> Jan
>
> > -Original Message-
> > From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED]
> > Sent: Tuesday, September 23, 2003 9:05 AM
> > To: [EMAIL PROTECTED]
> > Subject: RE: concat teardown failing
> >
> >
> > And I
23, 2003 9:05 AM
> To: [EMAIL PROTECTED]
> Subject: RE: concat teardown failing
>
>
> And I thought that´s only on my machine ... (that´s why I put that
> into a try-catch block in the tearDown() - the _real_ test shouldn´t
> fail only because the cleanup fails ...)
>
>
And I thought that´s only on my machine ... (that´s why I put that
into a try-catch block in the tearDown() - the _real_ test shouldn´t
fail only because the cleanup fails ...)
"task not closing things" - I will take a look into that.
While programming I use java.io.FileReader without a close (I h
15 matches
Mail list logo
