RE: Adding branch option to cvschangelog

2004-01-28 Thread Dominique Devienne
> From: Peter Reilly [mailto:[EMAIL PROTECTED] > >Well, that can surely break BC Peter if one used to cast a TaskDef into a > >Definer, no? Sure, it's not sensible code, but it's not 100% BC. All the > >old methods might still be there, so it's only 99.999% BC, which is fine > >by me ;-) I'm just n

Re: Adding branch option to cvschangelog

2004-01-28 Thread Antoine Lévy-Lambert
Peter Reilly wrote: Antoine Lévy-Lambert wrote: Does it break *BC* if I change the ChangeLogTask class to inherit from AbstractCvsTask instead of Task ? I do not think so. It is allowed to add new methods to a class, so adding a new super class should not be a problem. I have done this with Task

Re: Adding branch option to cvschangelog

2004-01-28 Thread Peter Reilly
Stefan Bodewig wrote: On Wed, 28 Jan 2004, Antoine Lévy-Lambert <[EMAIL PROTECTED]> wrote: Does it break *BC* if I change the ChangeLogTask class to inherit from AbstractCvsTask instead of Task ? Yes and no - but not too bad, I'd say. If you replace methods in ChangeLogTask with methods fro

Re: Adding branch option to cvschangelog

2004-01-28 Thread Stefan Bodewig
On Wed, 28 Jan 2004, Antoine Lévy-Lambert <[EMAIL PROTECTED]> wrote: > Does it break *BC* if I change the ChangeLogTask class to inherit > from AbstractCvsTask instead of Task ? Yes and no - but not too bad, I'd say. If you replace methods in ChangeLogTask with methods from AbstractCvsTask, clas

Re: Adding branch option to cvschangelog

2004-01-28 Thread Peter Reilly
Dominique Devienne wrote: From: Peter Reilly [mailto:[EMAIL PROTECTED] Antoine Lévy-Lambert wrote: Does it break *BC* if I change the ChangeLogTask class to inherit from AbstractCvsTask instead of Task ? I do not think so. It is allowed to add new methods to a class, so adding a new sup

RE: Adding branch option to cvschangelog

2004-01-28 Thread Dominique Devienne
> From: Peter Reilly [mailto:[EMAIL PROTECTED] > Antoine Lévy-Lambert wrote: > > Does it break *BC* if I change the ChangeLogTask class to inherit from > > AbstractCvsTask instead of Task ? > > I do not think so. > It is allowed to add new methods to a class, so adding a new super class > should n

Re: Adding branch option to cvschangelog

2004-01-28 Thread Peter Reilly
Antoine Lévy-Lambert wrote: Does it break *BC* if I change the ChangeLogTask class to inherit from AbstractCvsTask instead of Task ? I do not think so. It is allowed to add new methods to a class, so adding a new super class should not be a problem. I have done this with TaskDef. In 1.6 it inheri