Re: Migration of Ant test to JUnit4

2014-04-13 Thread Jean-Louis Boudart
Great job ! 2014-04-12 15:37 GMT+02:00 Michael Clarke : > Hi, > > I've now completed the migration of Ant's test cases to JUnit4 and would > like to give other developers a chance to review/comment on these changes > before I merge them back into SVN. My changes can be found on Github at > https

Re: Migration of Ant test to JUnit4

2014-04-13 Thread Antoine Levy Lambert
Hi, I sent my email too fast, it looks like your antjunit4 fork is already incorporating my changes. All is well then. Antoine On Apr 13, 2014, at 9:20 PM, Antoine Levy Lambert wrote: > Hello Michael, > > this is great. > > Since you started your fork, there have been changes done by Jan Ma

Re: Migration of Ant test to JUnit4

2014-04-13 Thread Antoine Levy Lambert
Hello Michael, this is great. Since you started your fork, there have been changes done by Jan Matèrne to detect Java 9 and by myself to use separate folders for each test - all under subfolders of ${java.io.tmpdir} Is it possible to rebase your fork first from https://github.com/apache/ant ?

Re: Migration of Ant test to JUnit4

2014-04-12 Thread Matt Sicker
This is pretty awesome! On 12 April 2014 07:37, Michael Clarke wrote: > Hi, > > I've now completed the migration of Ant's test cases to JUnit4 and would > like to give other developers a chance to review/comment on these changes > before I merge them back into SVN. My changes can be found on Gi

Migration of Ant test to JUnit4

2014-04-12 Thread Michael Clarke
Hi, I've now completed the migration of Ant's test cases to JUnit4 and would like to give other developers a chance to review/comment on these changes before I merge them back into SVN. My changes can be found on Github at https://github.com/mc1arke/ant/tree/JUnit4Conversion ( https://github.com/m