RE: Ivy svn breaks ant-contrib svn

2008-07-21 Thread Scheper, Erik-Berndt
-or make a new beta release with the original behaviour. Regards, Erik-Berndt Van: Stefan Bodewig [mailto:[EMAIL PROTECTED] Verzonden: vr 18-7-2008 17:33 Aan: dev@ant.apache.org Onderwerp: Re: Ivy svn breaks ant-contrib svn On Thu, 17 Jul 2008, Xavier Han

Re: Ivy svn breaks ant-contrib svn

2008-07-18 Thread Stefan Bodewig
On Thu, 17 Jul 2008, Xavier Hanin <[EMAIL PROTECTED]> wrote: > On Thu, Jul 17, 2008 at 10:00 AM, Stefan Bodewig <[EMAIL PROTECTED]> wrote: > >> I don't really have an opinion on the particular change but am a >> strong proponent of not breaking APIs in general (at least not >> without a deprecatio

Re: Ivy svn breaks ant-contrib svn

2008-07-18 Thread Stefan Bodewig
On Thu, 17 Jul 2008, Maarten Coene <[EMAIL PROTECTED]> wrote: > Just a wild guess, but maybe you could use IvyAntSettings again > (like your original code was), I thought so myself and had a quick look, but I'm neither familiar enough with Ivy nor what the ant-contrib task is trying to do that I

Re: [SPAM] Re: Ivy svn breaks ant-contrib svn

2008-07-17 Thread Xavier Hanin
meframe between beta-1 and beta-2. > > Erik-Berndt > > > > Van: Maarten Coene [mailto:[EMAIL PROTECTED] > Verzonden: do 17-7-2008 11:45 > Aan: Ant Developers List > Onderwerp: [SPAM] Re: Ivy svn breaks ant-contrib svn > > > > Just a wild guess, but maybe y

RE: [SPAM] Re: Ivy svn breaks ant-contrib svn

2008-07-17 Thread Scheper, Erik-Berndt
M] Re: Ivy svn breaks ant-contrib svn Just a wild guess, but maybe you could use IvyAntSettings again (like your original code was), but instead of calling the execute method you can register it yourself as Reference in the Project, something like: IvyAntSettings settings = new IvyAntSet

Re: Ivy svn breaks ant-contrib svn

2008-07-17 Thread Maarten Coene
().addReference(settingsId, settings); Maarten - Original Message From: Stefan Bodewig <[EMAIL PROTECTED]> To: dev@ant.apache.org Sent: Tuesday, July 15, 2008 2:13:10 PM Subject: Re: Ivy svn breaks ant-contrib svn On Tue, 15 Jul 2008, Xavier Hanin <[EMAIL PROTECTED]> wrote: >

Re: Ivy svn breaks ant-contrib svn

2008-07-17 Thread Xavier Hanin
On Thu, Jul 17, 2008 at 10:00 AM, Stefan Bodewig <[EMAIL PROTECTED]> wrote: > On Wed, 16 Jul 2008, Xavier Hanin <[EMAIL PROTECTED]> wrote: > > > Yes, I think setSettingsId is the good method to call, 2.0.0-beta2 was > > broken in that sense. Introducing a setId method for backward > compatiblity >

Re: Ivy svn breaks ant-contrib svn

2008-07-17 Thread Stefan Bodewig
On Wed, 16 Jul 2008, Xavier Hanin <[EMAIL PROTECTED]> wrote: > Yes, I think setSettingsId is the good method to call, 2.0.0-beta2 was > broken in that sense. Introducing a setId method for backward compatiblity > with something broken in concept doesn't sound really nice IMO. We will > probably fo

Re: Ivy svn breaks ant-contrib svn

2008-07-16 Thread Xavier Hanin
On Tue, Jul 15, 2008 at 2:13 PM, Stefan Bodewig <[EMAIL PROTECTED]> wrote: > On Tue, 15 Jul 2008, Xavier Hanin <[EMAIL PROTECTED]> wrote: > > > On Tue, Jul 15, 2008 at 9:23 AM, Stefan Bodewig <[EMAIL PROTECTED]> > wrote: > > > > > On Tue, 15 Jul 2008, Xavier Hanin <[EMAIL PROTECTED]> wrote: > > >

Re: Ivy svn breaks ant-contrib svn

2008-07-15 Thread Stefan Bodewig
On Tue, 15 Jul 2008, Xavier Hanin <[EMAIL PROTECTED]> wrote: > On Tue, Jul 15, 2008 at 9:23 AM, Stefan Bodewig <[EMAIL PROTECTED]> wrote: > > > On Tue, 15 Jul 2008, Xavier Hanin <[EMAIL PROTECTED]> wrote: > > > > > On Tue, Jul 15, 2008 at 8:53 AM, Stefan Bodewig <[EMAIL PROTECTED]> > > wrote: > >

Re: Ivy svn breaks ant-contrib svn

2008-07-15 Thread Xavier Hanin
On Tue, Jul 15, 2008 at 9:23 AM, Stefan Bodewig <[EMAIL PROTECTED]> wrote: > On Tue, 15 Jul 2008, Xavier Hanin <[EMAIL PROTECTED]> wrote: > > > On Tue, Jul 15, 2008 at 8:53 AM, Stefan Bodewig <[EMAIL PROTECTED]> > wrote: > > > > > On Mon, 14 Jul 2008, Stefan Bodewig <[EMAIL PROTECTED]> wrote: > >

Re: Ivy svn breaks ant-contrib svn

2008-07-15 Thread Stefan Bodewig
On Tue, 15 Jul 2008, Xavier Hanin <[EMAIL PROTECTED]> wrote: > On Tue, Jul 15, 2008 at 8:53 AM, Stefan Bodewig <[EMAIL PROTECTED]> wrote: > > > On Mon, 14 Jul 2008, Stefan Bodewig <[EMAIL PROTECTED]> wrote: > > > > On Mon, 14 Jul 2008, Maarten Coene <[EMAIL PROTECTED]> wrote: > > > > >> I changed

Re: Ivy svn breaks ant-contrib svn

2008-07-15 Thread Xavier Hanin
On Tue, Jul 15, 2008 at 8:53 AM, Stefan Bodewig <[EMAIL PROTECTED]> wrote: > On Mon, 14 Jul 2008, Stefan Bodewig <[EMAIL PROTECTED]> wrote: > > On Mon, 14 Jul 2008, Maarten Coene <[EMAIL PROTECTED]> wrote: > > >> I changed that recently. IvyAntSettings is now a DataType again... > >> They should u

Re: Ivy svn breaks ant-contrib svn

2008-07-14 Thread Stefan Bodewig
On Mon, 14 Jul 2008, Stefan Bodewig <[EMAIL PROTECTED]> wrote: On Mon, 14 Jul 2008, Maarten Coene <[EMAIL PROTECTED]> wrote: >> I changed that recently. IvyAntSettings is now a DataType again... >> They should use the IvyConfigure task instead. > > OK, thanks. Looked straight forward so I just

Re: Ivy svn breaks ant-contrib svn

2008-07-14 Thread Stefan Bodewig
On Mon, 14 Jul 2008, Maarten Coene <[EMAIL PROTECTED]> wrote: > I changed that recently. IvyAntSettings is now a DataType again... > They should use the IvyConfigure task instead. OK, thanks. Looked straight forward so I just committed the necessary patch. Stefan --

Re: Ivy svn breaks ant-contrib svn

2008-07-14 Thread Maarten Coene
Yes, I changed that recently. IvyAntSettings is now a DataType again... They should use the IvyConfigure task instead. Maarten - Original Message From: Stefan Bodewig <[EMAIL PROTECTED]> To: dev@ant.apache.org Sent: Monday, July 14, 2008 9:37:03 AM Subject: Ivy svn brea

Ivy svn breaks ant-contrib svn

2008-07-14 Thread Stefan Bodewig
Hi, just a quick note from Gump Since I'm not familiar enough with either Ivy or ant-contrib's usage of it, I can't say who's wrong. It looks as if ant-contrib expects IvyAntSettings to ex