RE: Checkstyle Audit

2003-07-08 Thread Dominique Devienne
Can't check.xml it from the Maven repository ;-) --DD > -Original Message- > From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] > Sent: Tuesday, July 08, 2003 2:02 AM > To: [EMAIL PROTECTED] > Subject: AW: Checkstyle Audit > > And you need the

AW: Checkstyle Audit

2003-07-08 Thread Jan . Materne
> On Fri, 4 Jul 2003 08:10 pm, Antoine Levy-Lambert wrote: > > Hi Conor, > > I am a beotian with xml/xsl. > > How do you run the style sheets yourself against the source > code of ant ? > > Antoine > > Had to look that one up. The check.xml file contains all the > tasks necessary > to run the a

Re: Checkstyle Audit

2003-07-04 Thread Conor MacNeill
On Fri, 4 Jul 2003 08:10 pm, Antoine Levy-Lambert wrote: > Hi Conor, > I am a beotian with xml/xsl. > How do you run the style sheets yourself against the source code of ant ? > Antoine Had to look that one up. The check.xml file contains all the tasks necessary to run the audit. Conor --

Re: Checkstyle Audit

2003-07-04 Thread Antoine Levy-Lambert
It sounds good. I wish I would know something about Gump to be able to help. Antoine - Original Message - From: "Conor MacNeill" <[EMAIL PROTECTED]> To: "Ant Developers List" <[EMAIL PROTECTED]> Sent: Friday, July 04, 2003 12:23 PM Subject: Re: Checkstyle Au

Re: Checkstyle Audit

2003-07-04 Thread Stefan Bodewig
On 04 Jul 2003, peter reilly <[EMAIL PROTECTED]> wrote: > I am surprised you do not see the tooltips I do now - and I'm no longer surprised. I must have disabled tooltips some time ago, can't remember why and when. Sorry for the noise Stefan ---

Re: Checkstyle Audit

2003-07-04 Thread peter reilly
I am surprised you do not see the tooltips The mozilla page http://www.mozilla.org/docs/web-developer/faq.html makes a little song and dance over suporting tooltips for the title attribute. Peter On Fri, 2003-07-04 at 12:50, Stefan Bodewig wrote: > On Fri, 4 Jul 2003, Conor MacNeill <[EMAIL PROTEC

Re: Checkstyle Audit

2003-07-04 Thread Stefan Bodewig
On Fri, 4 Jul 2003, Conor MacNeill <[EMAIL PROTECTED]> wrote: > The pages validate by w3c.org so maybe a bug in Mozilla 1.4? I don't think that the W3C tests whether the title attribute generates a tooltip 8-) Peter says that it works for him, which is strange. I'll simply accept it as an incon

Re: Checkstyle Audit

2003-07-04 Thread Conor MacNeill
On Fri, 4 Jul 2003 08:51 pm, Stefan Bodewig wrote: > On Fri, 4 Jul 2003, Conor MacNeill <[EMAIL PROTECTED]> > > wrote: > > Works on Mozilla 1.2.1 on Linux :-( It is just a title attribute in > > an anchor with no href. > > It seems as if the href was required for it to work in 1.4. > The pages val

Re: Checkstyle Audit

2003-07-04 Thread peter reilly
I just downloaded mozilla 1.4, and the tooltips work fine on Linux. Peter On Fri, 2003-07-04 at 11:51, Stefan Bodewig wrote: > On Fri, 4 Jul 2003, Conor MacNeill <[EMAIL PROTECTED]> > wrote: > > > Works on Mozilla 1.2.1 on Linux :-( It is just a title attribute in > > an anchor with no href. > >

Re: Checkstyle Audit

2003-07-04 Thread Antoine Levy-Lambert
Hi Conor, I am a beotian with xml/xsl. How do you run the style sheets yourself against the source code of ant ? Antoine - Original Message - From: "Conor MacNeill" <[EMAIL PROTECTED]> To: <[EMAIL PROTECTED]> Sent: Thursday, July 03, 2003 4:26 PM Subject: Checkstyle

Re: Checkstyle Audit

2003-07-04 Thread Stefan Bodewig
On Fri, 4 Jul 2003, Conor MacNeill <[EMAIL PROTECTED]> wrote: > Works on Mozilla 1.2.1 on Linux :-( It is just a title attribute in > an anchor with no href. It seems as if the href was required for it to work in 1.4. Stefan -

Re: Checkstyle Audit

2003-07-04 Thread Conor MacNeill
On Fri, 4 Jul 2003 08:26 pm, peter reilly wrote: > If that is done, the java-docs should also be included. > > In any case, it is easy to run the check locally (once > one figures out that ant -f check.xml checkstyle needs > to be run before ant -f check.xml ;-) > Peter > :-) I just did that while

Re: Checkstyle Audit

2003-07-04 Thread Conor MacNeill
On Fri, 4 Jul 2003 08:23 pm, Stefan Bodewig wrote: > On Fri, 4 Jul 2003, Conor MacNeill <[EMAIL PROTECTED]> > > wrote: > > If you hover over a line in the detail report it will show which > > checkstyle module triggered the report. > > Doesn't seem to work for Mozilla 1.4 on Linux. > Works on Mozi

AW: Checkstyle Audit

2003-07-04 Thread Jan . Materne
> > It's ad-hoc at the moment. What I would like is to create > an ant-site or > > ant-reports project in Gump and run it nightly from there. > It would need more > > work on the HTML generation from the generated xdocs. It could also > > incorporate the xdocs manual generation. We may need to

Re: Checkstyle Audit

2003-07-04 Thread Stefan Bodewig
On Fri, 4 Jul 2003, Conor MacNeill <[EMAIL PROTECTED]> wrote: > If you hover over a line in the detail report it will show which > checkstyle module triggered the report. Doesn't seem to work for Mozilla 1.4 on Linux. Stefan -

Re: Checkstyle Audit

2003-07-04 Thread peter reilly
On Fri, 2003-07-04 at 11:23, Conor MacNeill wrote: > On Fri, 4 Jul 2003 05:32 pm, Antoine Levy-Lambert wrote: > > Hi Conor, > > > > actually, it might be even better if the pages were generated by a cron job > > running daily, or even better, if a kind of cvs commit daemon would > > regenerate the

Re: Checkstyle Audit

2003-07-04 Thread Conor MacNeill
On Fri, 4 Jul 2003 05:32 pm, Antoine Levy-Lambert wrote: > Hi Conor, > > actually, it might be even better if the pages were generated by a cron job > running daily, or even better, if a kind of cvs commit daemon would > regenerate the pages corresponding to each changed source file. > It's ad-hoc

Re: Checkstyle Audit

2003-07-04 Thread Antoine Levy-Lambert
t; <[EMAIL PROTECTED]> To: "Ant Developers List" <[EMAIL PROTECTED]> Sent: Friday, July 04, 2003 1:13 AM Subject: Re: Checkstyle Audit > On Fri, 4 Jul 2003 01:15 am, peter reilly wrote: > > Excellent work. > > I have a problem with three rules: > > > >

Re: Checkstyle Audit

2003-07-03 Thread Conor MacNeill
On Fri, 4 Jul 2003 01:15 am, peter reilly wrote: > Excellent work. > I have a problem with three rules: > >major: The "DesignForExtensionCheck" seems a bit silly. >minor: The "LeftCurlyCheck" is against my in-house rule that > if there is a multi line condition, the { should be >

Re: Checkstyle Audit

2003-07-03 Thread Gus Heck
minor: "RedundantThrowsCheck: It complains about BuildException. So is it prefered to eliminate the throws BuildException? or keep it? I'm willing to fix my code if I know what is actually desired here. Gus - To unsubscribe, e

Re: Checkstyle Audit

2003-07-03 Thread peter reilly
I know ... Ah well, Peter On Thu, 2003-07-03 at 16:30, Stefan Bodewig wrote: > On 03 Jul 2003, peter reilly <[EMAIL PROTECTED]> wrote: > > >minor: The "LeftCurlyCheck" is against my in-house rule that > > if there is a multi line condition, the { should be > > on a separa

Re: Checkstyle Audit

2003-07-03 Thread Stefan Bodewig
On 03 Jul 2003, peter reilly <[EMAIL PROTECTED]> wrote: >minor: The "LeftCurlyCheck" is against my in-house rule that > if there is a multi line condition, the { should be > on a separate line - but I can live the rule. You inhouse rule is against Ant's coding style, which

Re: Checkstyle Audit

2003-07-03 Thread peter reilly
I can live the rule. minor: "RedundantThrowsCheck: It complains about BuildException. Peter On Thu, 2003-07-03 at 15:26, Conor MacNeill wrote: > I've done a checkstyle audit with the new xdoc generating stylesheets and > uploaded this to the server > > http://ant.apache.or

Checkstyle Audit

2003-07-03 Thread Conor MacNeill
I've done a checkstyle audit with the new xdoc generating stylesheets and uploaded this to the server http://ant.apache.org/reports/checkstyle/ It's not linked into the rest of the site (nor is it in CVS). It's mainly just for interest at the moment. It does show which