Re: Advice required on committing

2003-05-28 Thread Steve Loughran
Stefan Bodewig wrote: On Wed, 28 May 2003, peter reilly <[EMAIL PROTECTED]> wrote: should I make a bugzilla entry or just commit the changes, with unit test and appropriate comment ? I almost never create bugzilla entries for bugs I find myself - neither do I for bug reports received

AW: Advice required on committing

2003-05-28 Thread Jan . Materne
But bug reports are sometimes not faster: http://nagoya.apache.org/bugzilla/show_bug.cgi?id=19056 ;-) Jan > -Ursprüngliche Nachricht- > Von: Stefan Bodewig [mailto:[EMAIL PROTECTED] > Gesendet am: Mittwoch, 28. Mai 2003 13:36 > An: [EMAIL PROTECTED] > Betreff: Re: Adv

Re: Advice required on committing

2003-05-28 Thread peter reilly
s, > Magesh > > - Original Message - > From: "peter reilly" <[EMAIL PROTECTED]> > To: <[EMAIL PROTECTED]> > Sent: Wednesday, May 28, 2003 6:57 AM > Subject: Advice required on committing > > > Hi, I have just been made a ant committer.

Re: Advice required on committing

2003-05-28 Thread Stefan Bodewig
On Wed, 28 May 2003, Jan Materne <[EMAIL PROTECTED]> wrote: > Oh, then I will send you my pathes via email and don´t open a > bug report. If you look at two of my more recent commits, you'll see that it may take eighteen months to get them applied that way 8-) Stefan

Re: Advice required on committing

2003-05-28 Thread Magesh Umasankar
esday, May 28, 2003 6:57 AM Subject: Advice required on committing Hi, I have just been made a ant committer. I have found a bug in ant's regular expession handling for replacing matched groups. Ant uses \n to identify the matched group, jdk14 and jakarta-oro uses $n to identify the group. Th

AW: Advice required on committing

2003-05-28 Thread Jan . Materne
Oh, then I will send you my pathes via email and don´t open a bug report. Jan > -Ursprüngliche Nachricht- > Von: Stefan Bodewig [mailto:[EMAIL PROTECTED] > Gesendet am: Mittwoch, 28. Mai 2003 13:26 > An: [EMAIL PROTECTED] > Betreff: Re: Advice required on committ

Re: Advice required on committing

2003-05-28 Thread Stefan Bodewig
On Wed, 28 May 2003, peter reilly <[EMAIL PROTECTED]> wrote: >should I make a bugzilla entry or just >commit the changes, with unit test and >appropriate comment ? I almost never create bugzilla entries for bugs I find myself - neither do I for bug reports received by email. Stefan

Advice required on committing

2003-05-28 Thread peter reilly
Hi, I have just been made a ant committer. I have found a bug in ant's regular expession handling for replacing matched groups. Ant uses \n to identify the matched group, jdk14 and jakarta-oro uses $n to identify the group. The code in ant correctly replaces the \ with $. However, it does not es