Re: buildStarted/Finished and subbuilds

2004-06-23 Thread Stefan Bodewig
On Thu, 24 Jun 2004, Conor MacNeill <[EMAIL PROTECTED]> wrote: > Well, you could still take the approach of removing the main build > listeners and then fire a SubBuildFinished on all the remaining > listeners that are BuildListener2. Yes, much like what Jose Alberto describes later. This would

RE: buildStarted/Finished and subbuilds

2004-06-23 Thread Jose Alberto Fernandez
> From: Stefan Bodewig [mailto:[EMAIL PROTECTED] > > Hi all, > > while investigating bug 8689 I realized that the Ant project > instances we create in Ant never fire the build started or > finished events. I'm not entirely sure that this is a good > thing (but it probably is), but we probabl

Re: buildStarted/Finished and subbuilds

2004-06-23 Thread Conor MacNeill
Stefan Bodewig wrote: On Wed, 23 Jun 2004, Conor MacNeill <[EMAIL PROTECTED]> wrote: Unfortunately this wouldn't help. * RecorderEntry wants to write something to the file in buildFinished, if we close the file in projectFinished, this would try to write to a closed file in the main build. * Si

and subbuilds

2004-06-23 Thread Stefan Bodewig
While lookin into the AntClassLoader thing I realized that keeps a static map keyed on the name attribute of the task. This means that two different subbuilds that use the same name attribute in a task will end up writing to the same file (and probably cause a lot of other problems as well). Th

Re: buildStarted/Finished and subbuilds

2004-06-23 Thread Stefan Bodewig
On Wed, 23 Jun 2004, Conor MacNeill <[EMAIL PROTECTED]> wrote: > The only alternative I could think of (without checking whether it > is feasible) would be to create BuildListener2 and add something > like ProjectStarted/ProjectFinished to it. These would be called in > Project.executeTargets for

Re: buildStarted/Finished and subbuilds

2004-06-23 Thread Conor MacNeill
Stefan Bodewig wrote: this is ugly, but any clean solution I could come up with is not backwards compatible (add a dispose method to BuildListener, make subbuilds fire buildFinished ...). Any better ideas? Sounds OK. The only alternative I could think of (without checking whether it is feasible) w

Re: buildStarted/Finished and subbuilds

2004-06-23 Thread Peter Reilly
The clean up you propose sounds very good. As regards whether the ant family tasks should fire build started and finished events. One may see these for , and but not for (or at least the way it is used by some scripts as a sub-routine call). In any case, as you say, it cannot be changed for backw

buildStarted/Finished and subbuilds

2004-06-23 Thread Stefan Bodewig
Hi all, while investigating bug 8689 I realized that the Ant project instances we create in Ant never fire the build started or finished events. I'm not entirely sure that this is a good thing (but it probably is), but we probably can't change it for backwards compatibility reasons anyway. This