Re: [patch] javadoc, name-hiding, if/else nesting

if (condition) { return a; } return b; over: if (condition) { return a; } else { return b; } Only real benefit is to get rid of compiler warnings. I'm ambivalent about either way being "more correct", but the fewer warnings I get the better IMHO, so I remove nesting of returns in else

Re: [patch] javadoc, name-hiding, if/else nesting

Thanks Kev, Committed the vs part. I do not really see the benefit of having if (condition) { return a; } return b; over: if (condition) { return a; } else { return b; } so I didn't apply those patches. I did apply the destDir -> baseDir one, but it left the javadoc in an inconsistent s

[patch] javadoc, name-hiding, if/else nesting

some tweaks, nothing major Kev Index: CollectionUtils.java === RCS file: /home/cvspublic/ant/src/main/org/apache/tools/ant/util/CollectionUtils.java,v retrieving revision 1.18 diff -u -r1.18 CollectionUtils.java --- CollectionUtils.ja