Re: [Patch] FileUtils to use own close method

2004-12-15 Thread Stefan Bodewig
On Mon, 13 Dec 2004, kj <[EMAIL PROTECTED]> wrote: > -FileUtils now uses close to close inputstreams inside itself I've applied this part of the patch, but have some more comments on the rest: > +int stackSize = s.size(); > while (tok.hasMoreTokens()) { > String thi

Re: [Patch] FileUtils to use own close method

2004-12-14 Thread kj
On Tue, 2004-12-14 at 10:40 +0100, Stefan Bodewig wrote: > That's why we have conditional compilations in Ant's build file - but > we can't compile a core service like FileUtils on JDK 1.4+ only. OK, thanks for explaining. Kev -

Re: [Patch] FileUtils to use own close method

2004-12-14 Thread Stefan Bodewig
On Tue, 14 Dec 2004, kj <[EMAIL PROTECTED]> wrote: > I was unaware of this requirement. Does this mean that the Regexp > package will compile with JDK1.2? Except for the Jdk14* classes, yes. The classes used by the core directly do. > but I doubt a 1.2 compiler will compile the Jdk14Regexp* cl

Re: [Patch] FileUtils to use own close method

2004-12-14 Thread kj
On Mon, 2004-12-13 at 10:42 +0100, Stefan Bodewig wrote: > On Mon, 13 Dec 2004, kj <[EMAIL PROTECTED]> wrote: > > > -added new private method to use java.nio memory mapped files > > Ant is JDK 1.2 compatible, which means we can't use NIO for core > functionality (at least not without falling back

Re: [Patch] FileUtils to use own close method

2004-12-13 Thread Stefan Bodewig
On Mon, 13 Dec 2004, kj <[EMAIL PROTECTED]> wrote: > -added new private method to use java.nio memory mapped files Ant is JDK 1.2 compatible, which means we can't use NIO for core functionality (at least not without falling back to reflection). Stefan ---

[Patch] FileUtils to use own close method

2004-12-13 Thread kj
-FileUtils now uses close to close inputstreams inside itself -added new private method to use java.nio memory mapped files for contentEquals method (this implementation doesn't care how large the files are, it simply tries to map the entire file, perhaps it would be better to check file size firs