Re: [Patch] ChangeLogParser - hiding field

2004-12-21 Thread Jesse Glick
Kev Jackson wrote: When writing a new class, start with static final class Foo {} I've read many times that declaring a class as final is a farily dangerous thing to do with code. Once you've made a class final people are stuck with what you decided at a particular moment was the right way to d

Re: [Patch] ChangeLogParser - hiding field

2004-12-20 Thread Kev Jackson
Jesse Glick wrote: Just jumping in here... :-) Feel free ;) kj wrote: -class ChangeLogParser { +public class ChangeLogParser { No really, just habit - company standards where I've worked in past etc. Did your company produce Java components with publicly visible APIs they were committed to prese

Re: [Patch] ChangeLogParser - hiding field

2004-12-18 Thread Jesse Glick
Just jumping in here... :-) kj wrote: -class ChangeLogParser { +public class ChangeLogParser { No really, just habit - company standards where I've worked in past etc. Did your company produce Java components with publicly visible APIs they were committed to preserving indefinitely? Seriously, mak

Re: [Patch] ChangeLogParser - hiding field

2004-12-17 Thread Stefan Bodewig
On Fri, 17 Dec 2004, kj <[EMAIL PROTECTED]> wrote: > No really, just habit - company standards where I've worked in past > etc. Changing it can't break BWC as it can only make the class more > visible not less visible. I agree, but it adds BWC problems for the future. I.e. one more classes with

Re: [Patch] ChangeLogParser - hiding field

2004-12-17 Thread kj
On Fri, 2004-12-17 at 12:29 +0100, Stefan Bodewig wrote: > On Fri, 17 Dec 2004, Kev Jackson <[EMAIL PROTECTED]> wrote: > > > -class ChangeLogParser { > > +public class ChangeLogParser { > > why? why not? ;) No really, just habit - company standards where I've worked in past etc. Changing it can'

Re: [Patch] ChangeLogParser - hiding field

2004-12-17 Thread Stefan Bodewig
On Fri, 17 Dec 2004, Kev Jackson <[EMAIL PROTECTED]> wrote: > -class ChangeLogParser { > +public class ChangeLogParser { why? Stefan - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]

[Patch] ChangeLogParser - hiding field

2004-12-17 Thread Kev Jackson
removed extra LOC from javadoc whilst I was there - no warnings about the whole cvslib now!! (have to make teh compiler even more strict ;) ) Index: ChangeLogParser.java === RCS file: /home/cvspublic/ant/src/main/org/apache/tools/a