HannesWell commented on PR #216:
URL: https://github.com/apache/ant/pull/216#issuecomment-2637707338
Thank you for your reviews and accepting this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
jaikiran merged PR #216:
URL: https://github.com/apache/ant/pull/216
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For
HannesWell commented on PR #216:
URL: https://github.com/apache/ant/pull/216#issuecomment-2635435720
> The reason I say we should avoid the check for Java 12 or such is because
although the "allow" and "disallow" values for the "java.security.manager"
system property were introduced in that
jaikiran commented on PR #216:
URL: https://github.com/apache/ant/pull/216#issuecomment-2551818231
Hello Hannes, caching the value is fine and what you propose here is
reasonable. My only suggestion would be to remove the reference and usage of
Java 12 check. I think if Java version is less
HannesWell commented on PR #216:
URL: https://github.com/apache/ant/pull/216#issuecomment-2549864805
Thanks for the quick feedback.
> That way Ant will continue to not set the SecurityManager for Java 18 or
higher and for lesser versions, Ant will then not set the SecurityManager, if
jaikiran commented on PR #216:
URL: https://github.com/apache/ant/pull/216#issuecomment-2543896795
Hello Hannes, I haven't had a chance to look at this in detail, but looking
at the linked issue, I think what should be done here is, only change the
implementation of `isSetSecurityManagerAll
HannesWell commented on PR #216:
URL: https://github.com/apache/ant/pull/216#issuecomment-2543892077
I have now changed this to be less intrusive and not relying on deprecated
(`SecurityManager`)-API.
On the other hand, the previous approach would also handle the case if a
security-m
HannesWell opened a new pull request, #216:
URL: https://github.com/apache/ant/pull/216
Since Java-12 users can configure a JVM to disallow the installation of a
SecurityManager at runtime. The default value of the configuration has changed
over the following versions and since Java-24 it's
