Re: [PR] Throw BuildExceptions in ReplaceRegExp for IOExceptions and missing files [ant]

2023-11-16 Thread via GitHub
mfaquan commented on PR #206: URL: https://github.com/apache/ant/pull/206#issuecomment-1815320520 > looks good, thank you. We'll also need to change the manual page, which I can do myself. > > If you want to be listed in Ant's contributor's list, please let us know which name you wan

Re: [PR] Throw BuildExceptions in ReplaceRegExp for IOExceptions and missing files [ant]

2023-11-16 Thread via GitHub
bodewig merged PR #206: URL: https://github.com/apache/ant/pull/206 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For

Re: [PR] Throw BuildExceptions in ReplaceRegExp for IOExceptions and missing files [ant]

2023-11-16 Thread via GitHub
bodewig commented on PR #206: URL: https://github.com/apache/ant/pull/206#issuecomment-1815261409 looks good, thank you. We'll also need to change the manual page, which I can do myself. If you want to be listed in Ant's contributor's list, please let us know which name you want us t

Re: [PR] Throw BuildExceptions in ReplaceRegExp for IOExceptions and missing files [ant]

2023-11-16 Thread via GitHub
mfaquan commented on PR #206: URL: https://github.com/apache/ant/pull/206#issuecomment-1815013377 > You are correct and I don't recall why the code works the way it does. But it has done so for more than 20 years now and changing it might break existing builds. Let me suggest to introduce a

Re: [PR] Throw BuildExceptions in ReplaceRegExp for IOExceptions and missing files [ant]

2023-11-16 Thread via GitHub
bodewig commented on PR #206: URL: https://github.com/apache/ant/pull/206#issuecomment-1814953625 You are correct and I don't recall why the code works the way it does. But it has done so for more than 20 years now and changing it might break existing builds. Let me suggest to introduce a `