[GitHub] [ant] Wade-tech commented on pull request #166: Support Jakarta Mail in MailLogger

2023-02-06 Thread via GitHub
Wade-tech commented on PR #166: URL: https://github.com/apache/ant/pull/166#issuecomment-1420290634 Hi ,tomcat10 change javax.* namespace to jakarta.*, Does ant now support jakarta.mail? -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [ant] tkowalcz commented on pull request #197: Handling forked VM timeout in a similar way to junit ant task

2023-02-06 Thread via GitHub
tkowalcz commented on PR #197: URL: https://github.com/apache/ant/pull/197#issuecomment-1419282632 Thanks. I will give it a try and let you know. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [ant] jaikiran commented on pull request #197: Handling forked VM timeout in a similar way to junit ant task

2023-02-06 Thread via GitHub
jaikiran commented on PR #197: URL: https://github.com/apache/ant/pull/197#issuecomment-1419267691 > When I build the project the tests do not seem to be executed Some of the tasks in Ant, including the `junitlauncher` aren't part of the "core". You will have to first fetch the depen

[GitHub] [ant] tkowalcz commented on pull request #197: Handling forked VM timeout in a similar way to junit ant task

2023-02-06 Thread via GitHub
tkowalcz commented on PR #197: URL: https://github.com/apache/ant/pull/197#issuecomment-1419257202 Hi, actually I had problems running the tests in the first place. When I build the project the tests do not seem to be executed (build pass even when I introduce failing assertion). I can late

[GitHub] [ant] jaikiran commented on pull request #197: Handling forked VM timeout in a similar way to junit ant task

2023-02-06 Thread via GitHub
jaikiran commented on PR #197: URL: https://github.com/apache/ant/pull/197#issuecomment-1419253719 Hello Tomasz, I don't want to rush you, but if writing a test is proving to be time consuming or complicated, do let me know and I'll merge this fix (which looks good to me) and I'll add a tes