[GitHub] [ant] jaikiran commented on pull request #197: Handling forked VM timeout in a similar way to junit ant task

2023-01-12 Thread GitBox
jaikiran commented on PR #197: URL: https://github.com/apache/ant/pull/197#issuecomment-1381175943 Thank you Tomasz for this PR. I think this change looks fine. Could you add a test case to verify this change works as expected. We have a junitlauncher test class at `src/tests/junit/org/apa

[GitHub] [ant] jaikiran commented on a diff in pull request #197: Handling forked VM timeout in a similar way to junit ant task

2023-01-12 Thread GitBox
jaikiran commented on code in PR #197: URL: https://github.com/apache/ant/pull/197#discussion_r1068816591 ## src/main/org/apache/tools/ant/taskdefs/optional/junitlauncher/confined/JUnitLauncherTask.java: ## @@ -330,7 +330,20 @@ private void forkTest(final TestDefinition test) {

[GitHub] [ant] jaikiran commented on a diff in pull request #197: Handling forked VM timeout in a similar way to junit ant task

2023-01-12 Thread GitBox
jaikiran commented on code in PR #197: URL: https://github.com/apache/ant/pull/197#discussion_r1068816123 ## src/main/org/apache/tools/ant/taskdefs/optional/junitlauncher/confined/JUnitLauncherTask.java: ## @@ -330,7 +330,20 @@ private void forkTest(final TestDefinition test) {