[GitHub] [ant-ivy] jaikiran commented on pull request #96: IVY-1632: Use valid value for HTTP header "Accept".

2021-12-22 Thread GitBox
jaikiran commented on pull request #96: URL: https://github.com/apache/ant-ivy/pull/96#issuecomment-130597 This looks OK to me. However, it looks like this PR didn't trigger a CI run, so I'll manually run our tests to make sure this doesn't break anything, before merging this. --

[GitHub] [ant] jaikiran commented on pull request #173: Allow ant:get task to disable authentication on redirect.

2021-12-22 Thread GitBox
jaikiran commented on pull request #173: URL: https://github.com/apache/ant/pull/173#issuecomment-129159 >Therefore I didn't change the default behavior to avoid breaking existing Ant scripts. This means, "authenticateOnRedirect" defaults to "true". But maybe it would be better to chan

Re: [DISCUSS] JUnit 5 Customization

2021-12-22 Thread Jaikiran Pai
Hello Aleksei, On 22/12/21 7:59 pm, Aleksei Zotov wrote: Hi Ant Developers, I'm working on the migration of Apache Cassandra project from JUnit 4 to JUnit 5 (CASSANDRA-16630 ) which turned out to be larger than I originally expected. At the

[GitHub] [ant] bodewig commented on pull request #173: Allow ant:get task to disable authentication on redirect.

2021-12-22 Thread GitBox
bodewig commented on pull request #173: URL: https://github.com/apache/ant/pull/173#issuecomment-999741812 many thanks @bernolanger we'd like to credit you in CONTRIBUTORS and contributors.xml. What is the name you'd want us to use? -- This is an automated message from the Apache

[GitHub] [ant] bodewig merged pull request #173: Allow ant:get task to disable authentication on redirect.

2021-12-22 Thread GitBox
bodewig merged pull request #173: URL: https://github.com/apache/ant/pull/173 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ant.

[DISCUSS] JUnit 5 Customization

2021-12-22 Thread Aleksei Zotov
Hi Ant Developers, I'm working on the migration of Apache Cassandra project from JUnit 4 to JUnit 5 (CASSANDRA-16630 ) which turned out to be larger than I originally expected. At the moment, three PRs got merged: - https://github.com/apac

[GitHub] [ant] azotcsit commented on a change in pull request #169: junitlauncher - Improved extensibility capabilities for formatters

2021-12-22 Thread GitBox
azotcsit commented on a change in pull request #169: URL: https://github.com/apache/ant/pull/169#discussion_r773913282 ## File path: src/main/org/apache/tools/ant/taskdefs/optional/junitlauncher/AbstractJUnitResultFormatter.java ## @@ -43,7 +43,7 @@ /** * Contains some comm

[GitHub] [ant] azotcsit opened a new pull request #174: junitlauncher - Added fork mode support

2021-12-22 Thread GitBox
azotcsit opened a new pull request #174: URL: https://github.com/apache/ant/pull/174 ### Context I'm working on migration of Cassandra to JUnit5 (https://issues.apache.org/jira/browse/CASSANDRA-16630). Our test running code is heavily customized and relies onto [forkMode](https://githu