[GitHub] [ant] arturobernalg commented on pull request #163: Make final var when is possible.

2021-10-05 Thread GitBox
arturobernalg commented on pull request #163: URL: https://github.com/apache/ant/pull/163#issuecomment-934565487 > @arturobernalg I'm by far not the only Ant committer, so please don't feel forced to close a PR just because I comment in an unfavorable way. HI @bodewig TY for the

Re: [VOTE] Release Apache Ant 1.10.12 based on RC1

2021-10-05 Thread Paul King
+0 (non-binding) I checked: * LICENSE & NOTICE seem okay * HASH & SIG seem okay * I ran against the Groovy test suite which has 100+ ant-related tests and all continue to pass (using JDK16 and the upcoming Groovy 4) I was surprised to see binary jars in the src archives under lib/optional. I don'

Re: [VOTE] Release Apache Ant 1.10.12 based on RC1

2021-10-05 Thread Maarten Coene
+1 Maarten Op donderdag 30 september 2021 04:58:56 CEST schreef Jaikiran Pai : I've created a release candidate for 1.10.12: git tag: ANT_1.10.12_RC1 on commit: cb7f242aa099c069bd75e6ee4d6e50b56fd73b71 tarballs: https://dist.apache.org/repos/dist/dev/ant/   revision: 5