[GitHub] [ant] bodewig merged pull request #159: Use an empty array in favor of pre-sized array.

bodewig merged pull request #159: URL: https://github.com/apache/ant/pull/159 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ant.

[GitHub] [ant] bodewig commented on a change in pull request #158: Replace assert by simpler but equivalent calls.

bodewig commented on a change in pull request #158: URL: https://github.com/apache/ant/pull/158#discussion_r716031134 ## File path: src/tests/junit/org/apache/tools/ant/util/DeweyDecimalTest.java ## @@ -107,10 +107,10 @@ public void isGreaterThanOrEqual() { @Test publ

[GitHub] [ant] bodewig commented on pull request #157: Performance:

bodewig commented on pull request #157: URL: https://github.com/apache/ant/pull/157#issuecomment-927108994 "performance" is such a big word, I very much doubt there will be any measurable effect on a real build by the changes :-) anyway, thanks for the patch @arturobernalg . Please b

[GitHub] [ant] bodewig commented on a change in pull request #157: Performance:

bodewig commented on a change in pull request #157: URL: https://github.com/apache/ant/pull/157#discussion_r716030810 ## File path: src/main/org/apache/tools/ant/taskdefs/compilers/JavacExternal.java ## @@ -94,9 +94,8 @@ private int moveArgFileEligibleOptionsToEnd(String[] com

[GitHub] [ant] bodewig commented on a change in pull request #155: Simplify single assignment and avoid redundant if conditions.

bodewig commented on a change in pull request #155: URL: https://github.com/apache/ant/pull/155#discussion_r716030510 ## File path: src/main/org/apache/tools/ant/taskdefs/XmlProperty.java ## @@ -404,17 +404,14 @@ public Object processNode(Node node, String prefix, Object conta

[GitHub] [ant] bodewig merged pull request #154: Change StringBuffer in favor of StringBuilder.

bodewig merged pull request #154: URL: https://github.com/apache/ant/pull/154 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ant.

[GitHub] [ant] bodewig merged pull request #153: Delete unused import.

bodewig merged pull request #153: URL: https://github.com/apache/ant/pull/153 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ant.

[GitHub] [ant] bodewig merged pull request #139: No boxing

bodewig merged pull request #139: URL: https://github.com/apache/ant/pull/139 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ant.

[GitHub] [ant] bodewig closed pull request #58: Use StringBuilder instead of StringBuffer as it offers high performan…

bodewig closed pull request #58: URL: https://github.com/apache/ant/pull/58 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ant.ap

[GitHub] [ant] bodewig closed pull request #45: Consider returning a zero length array rather than null.

bodewig closed pull request #45: URL: https://github.com/apache/ant/pull/45 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ant.ap

[GitHub] [ant] bodewig commented on pull request #142: Tar-task: using should preserve symlinks

bodewig commented on pull request #142: URL: https://github.com/apache/ant/pull/142#issuecomment-927106646 many thanks @mstrap I'd like to add you to the contributors list (CONTRIBUTORS and contributors.xml), which name shall I use? -- This is an automated message from the Apache

[GitHub] [ant] asfgit merged pull request #142: Tar-task: using should preserve symlinks

asfgit merged pull request #142: URL: https://github.com/apache/ant/pull/142 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ant.a