Bug report for Ant [2021/03/14]

2021-03-13 Thread bugzilla
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned

[GitHub] [ant] bodewig merged pull request #145: Override ZipOutputStream.write(int)

2021-03-13 Thread GitBox
bodewig merged pull request #145: URL: https://github.com/apache/ant/pull/145 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[GitHub] [ant] bodewig commented on pull request #145: Override ZipOutputStream.write(int)

2021-03-13 Thread GitBox
bodewig commented on pull request #145: URL: https://github.com/apache/ant/pull/145#issuecomment-798341657 Ant predates Commons Compress by several years. Actually Ant's core doesn't have any dependencies at all, this has always been the case. Initially the XML parser had to be provi

[GitHub] [ant] helfper commented on pull request #145: Override ZipOutputStream.write(int)

2021-03-13 Thread GitBox
helfper commented on pull request #145: URL: https://github.com/apache/ant/pull/145#issuecomment-798310215 @bodewig I've updated the contributors files now. I've found the issue in https://github.com/johnrengelman/shadow which uses Ant's `ZipOutputStream`. Out of curiosity, why doesn

[GitHub] [ant] helfper commented on a change in pull request #145: Override ZipOutputStream.write(int)

2021-03-13 Thread GitBox
helfper commented on a change in pull request #145: URL: https://github.com/apache/ant/pull/145#discussion_r593746440 ## File path: src/tests/junit/org/apache/tools/zip/ZipOutputStreamTest.java ## @@ -70,4 +76,17 @@ public void testAdjustToLong() { ZipUtil

[GitHub] [ant] helfper commented on a change in pull request #145: Override ZipOutputStream.write(int)

2021-03-13 Thread GitBox
helfper commented on a change in pull request #145: URL: https://github.com/apache/ant/pull/145#discussion_r593746382 ## File path: src/main/org/apache/tools/zip/ZipOutputStream.java ## @@ -901,6 +901,20 @@ public boolean canWriteEntryData(ZipEntry ae) { return ZipUtil

[GitHub] [ant] helfper commented on a change in pull request #145: Override ZipOutputStream.write(int)

2021-03-13 Thread GitBox
helfper commented on a change in pull request #145: URL: https://github.com/apache/ant/pull/145#discussion_r593746382 ## File path: src/main/org/apache/tools/zip/ZipOutputStream.java ## @@ -901,6 +901,20 @@ public boolean canWriteEntryData(ZipEntry ae) { return ZipUtil

Re: Selectors not executed on Zipfileset

2021-03-13 Thread Stefan Bodewig
On 2021-03-08, Gilles Querret wrote: > I think I've found an issue with selectors which are not executed on > Zipfileset. Here is a very small test case to reproduce the issue: The selectors that can be nested directly into a fileset (and this into a zipfileset which inherits the behavior) are Fi

[GitHub] [ant] bodewig commented on pull request #145: Override ZipOutputStream.write(int)

2021-03-13 Thread GitBox
bodewig commented on pull request #145: URL: https://github.com/apache/ant/pull/145#issuecomment-798236533 Many thanks - interesting this has been there for more then a decade. Most likely this is because Ant is supposed to be the only consumer of the class and doesn't use the single byte

[GitHub] [ant] bodewig commented on a change in pull request #145: Override ZipOutputStream.write(int)

2021-03-13 Thread GitBox
bodewig commented on a change in pull request #145: URL: https://github.com/apache/ant/pull/145#discussion_r593741717 ## File path: src/tests/junit/org/apache/tools/zip/ZipOutputStreamTest.java ## @@ -70,4 +76,17 @@ public void testAdjustToLong() { ZipUtil

[GitHub] [ant] bodewig commented on a change in pull request #145: Override ZipOutputStream.write(int)

2021-03-13 Thread GitBox
bodewig commented on a change in pull request #145: URL: https://github.com/apache/ant/pull/145#discussion_r593741630 ## File path: src/main/org/apache/tools/zip/ZipOutputStream.java ## @@ -901,6 +901,20 @@ public boolean canWriteEntryData(ZipEntry ae) { return ZipUtil

[GitHub] [ant] helfper opened a new pull request #145: Override ZipOutputStream.write(int)

2021-03-13 Thread GitBox
helfper opened a new pull request #145: URL: https://github.com/apache/ant/pull/145 `java.util.zip.ZipOutputStream` extends from `java.util.zip.DeflaterOutputStream` which overrides `void write(int b)` to redirect its calls to `void write(byte[] b, int off, int len)`. `org.apache.to