Re: Ant JUnit tests

2018-04-20 Thread Gintautas Grigelionis
2018-04-20 17:34 GMT+00:00 Nicolas Lalevée : > > > Le 20 avr. 2018 à 18:48, Gintautas Grigelionis > a écrit : > > > > 2018-04-20 15:26 GMT+00:00 Nicolas Lalevée >: > > > >>> Le 20 avr. 2018 à 07:09, Gintautas Grigelionis < > g.grigelio...@gmail.com> a écrit : >

Re: Ant JUnit tests

2018-04-20 Thread Nicolas Lalevée
> Le 20 avr. 2018 à 18:48, Gintautas Grigelionis a > écrit : > > 2018-04-20 15:26 GMT+00:00 Nicolas Lalevée >: > >>> Le 20 avr. 2018 à 07:09, Gintautas Grigelionis >> a écrit : >>> >>> I am refactoring Ant JUnit tests with a goal to make them more >>> "ID

Re: Ant JUnit tests

2018-04-20 Thread Gintautas Grigelionis
2018-04-20 15:26 GMT+00:00 Nicolas Lalevée : > > Le 20 avr. 2018 à 07:09, Gintautas Grigelionis > a écrit : > > > > I am refactoring Ant JUnit tests with a goal to make them more > > "IDE-friendly". I found several tests that are implictly dependent on > > ant.home property being set. In these ca

Re: Ant JUnit tests

2018-04-20 Thread Nicolas Lalevée
> Le 20 avr. 2018 à 07:09, Gintautas Grigelionis a > écrit : > > I am refactoring Ant JUnit tests with a goal to make them more > "IDE-friendly". I found several tests that are implictly dependent on > ant.home property being set. In these cases, the test should be prevented > from execution b

Re: Ant JUnit tests

2018-04-20 Thread Gintautas Grigelionis
That's what an assumption is for -- checking for preconditions. Lack of preconditions does not mean the test should fail, it should not be executed at all in order to avoid false negatives. As I said, I will make assumptions explicit. My question was, should I provide more information, like, what i

AW: Ant JUnit tests

2018-04-20 Thread jhm
Why not an assert with a meaningful message to test if the property is set? Jan > -Ursprüngliche Nachricht- > Von: Gintautas Grigelionis [mailto:g.grigelio...@gmail.com] > Gesendet: Freitag, 20. April 2018 10:42 > An: Ant Developers List > Betreff: Re: Ant JUnit tests > > Assumption is a

Re: Ant JUnit tests

2018-04-20 Thread Gintautas Grigelionis
Assumption is a "friendly reminder" -- the test is does not run unless the assumption is valid; the assumption provides an explanation of what is missing. My question was about how friendly we should be. Gintas 2018-04-20 7:14 GMT+02:00 Jaikiran Pai : > Like discussed in the other thread, I don'