[GitHub] ant-ivy pull request #71: Ivy main/standalone: Patch to include 'makepom' fu...

2018-03-28 Thread twogee
Github user twogee commented on a diff in the pull request: https://github.com/apache/ant-ivy/pull/71#discussion_r177857645 --- Diff: src/java/org/apache/ivy/Main.java --- @@ -199,6 +201,10 @@ static CommandLineParser getParser() { new OptionBuilder("cp").ar

[GitHub] ant-ivy pull request #71: Ivy main/standalone: Patch to include 'makepom' fu...

2018-03-28 Thread twogee
Github user twogee commented on a diff in the pull request: https://github.com/apache/ant-ivy/pull/71#discussion_r177696348 --- Diff: src/java/org/apache/ivy/Main.java --- @@ -199,6 +201,10 @@ static CommandLineParser getParser() { new OptionBuilder("cp").ar

[GitHub] ant-ivy pull request #71: Ivy main/standalone: Patch to include 'makepom' fu...

2018-03-28 Thread jaikiran
Github user jaikiran commented on a diff in the pull request: https://github.com/apache/ant-ivy/pull/71#discussion_r177694759 --- Diff: src/java/org/apache/ivy/Main.java --- @@ -199,6 +201,10 @@ static CommandLineParser getParser() { new OptionBuilder("cp").

[GitHub] ant-ivy pull request #71: Ivy main/standalone: Patch to include 'makepom' fu...

2018-03-28 Thread jaikiran
Github user jaikiran commented on a diff in the pull request: https://github.com/apache/ant-ivy/pull/71#discussion_r177694862 --- Diff: src/java/org/apache/ivy/Main.java --- @@ -199,6 +201,10 @@ static CommandLineParser getParser() { new OptionBuilder("cp").

[GitHub] ant-ivy issue #71: Ivy main/standalone: Patch to include 'makepom' function

2018-03-28 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant-ivy/pull/71 @aanno Thank you for the patch. This mostly looks fine. I have added some review comments. Can you please also introduce a test case for this? Something that tests that these command options are rec