[GitHub] ant issue #50: Use newer Maven Ant tasks

Github user twogee commented on the issue: https://github.com/apache/ant/pull/50 I hope the third time is the charm 😄 A couple of wishes for antunit: it should have ant/ant-launcher as "provided" dependencies and it should have a "tempdir" attribute similar to junit task.

Re: Potential breaking change to symlink task [ was Re: Jenkins build became unstable: Ant-Build-Matrix-master-Linux » JDK 1.8 (latest) #977]

[@Steve I'm trying to drag you in as you've been the one who brought in the change that gets contested by https://bz.apache.org/bugzilla/show_bug.cgi?id=58683 and maybe you recall the details better than we do.] On 2017-12-10, Jaikiran Pai wrote: > On 10/12/17 3:09 PM, Stefan Bodewig wrote: >> On

Potential breaking change to symlink task [ was Re: Jenkins build became unstable: Ant-Build-Matrix-master-Linux » JDK 1.8 (latest) #977]

On 10/12/17 3:09 PM, Stefan Bodewig wrote: On 2017-12-10, Jaikiran Pai wrote: I'll investigate why this is failing (local tests pass for me) and fix it. Target testCreateOverFile in the antunit test explicitly tries to replace a file with a link, doing exactly what the bugzilla report says i

Re: Jenkins build became unstable: Ant-Build-Matrix-master-Linux » JDK 1.8 (latest) #977

You are right, that indeed was the issue (for one of that failing test). I have pushed a commit with this change to fix that one. -Jaikiran On 10/12/17 3:13 PM, Stefan Bodewig wrote: On 2017-12-10, Stefan Bodewig wrote: testCreateDoubleHanging is related to https://bz.apache.org/bugzilla/sh

[GitHub] ant issue #50: Use newer Maven Ant tasks

Github user bodewig commented on the issue: https://github.com/apache/ant/pull/50 :+1: --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org

Re: Jenkins build became unstable: Ant-Build-Matrix-master-Linux » JDK 1.8 (latest) #977

On 2017-12-10, Stefan Bodewig wrote: > testCreateDoubleHanging is related to > https://bz.apache.org/bugzilla/show_bug.cgi?id=38199 judging from the > history. Here the link points to a non-existent file and Files.exists > returns false in Java8. fixed by @@ -37,6 +37,7 @@ import java.io.IOExcep

Re: Jenkins build became unstable: Ant-Build-Matrix-master-Linux » JDK 1.8 (latest) #977

On 2017-12-10, Jaikiran Pai wrote: > I'll investigate why this is failing (local tests pass for me) and fix it. Are you using Java9 locally? The test only fail for Java8 in Jenkins, this could explain the difference. The antunit tests fail for me with Java 8 as well, while the JUnit test passes.

[GitHub] ant issue #50: Use newer Maven Ant tasks

Github user twogee commented on the issue: https://github.com/apache/ant/pull/50 This is exactly why I was looking into it -- those things tend to deteriorate over time 😄 To sum it up, I'll revert stripping, restore CPL and correct the README (that tests rely on JUnit 3 be

Re: Jenkins build became unstable: Ant-Build-Matrix-master-Linux » JDK 1.8 (latest) #977

I'll investigate why this is failing (local tests pass for me) and fix it. -Jaikiran On 10/12/17 2:29 PM, Apache Jenkins Server wrote: See -

[GitHub] ant issue #50: Use newer Maven Ant tasks

Github user bodewig commented on the issue: https://github.com/apache/ant/pull/50 Thank you. The junit 4 situation is a bit weird, even more than I recalled it to be. I didn't remember us stripping classes from the jar and don't think this is true for the 4.11 jar in our repo

[GitHub] ant issue #49: [master branch] - Fix BZ-58683

Github user jaikiran commented on the issue: https://github.com/apache/ant/pull/49 Committed to master branch https://github.com/apache/ant/commit/cefdbd398d8e310b218f9e2ca6f0b7fb13eddbb9 --- - To unsubscribe, e-ma

[GitHub] ant pull request #49: [master branch] - Fix BZ-58683

Github user jaikiran closed the pull request at: https://github.com/apache/ant/pull/49 --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org

[GitHub] ant issue #49: [master branch] - Fix BZ-58683

Github user bodewig commented on the issue: https://github.com/apache/ant/pull/49 Looks good to me, thanks! WRT a Java5 compatible backport, I'd leave this really up to you. I don't see a pressing need for backporting either. ---

[GitHub] ant pull request #49: [master branch] - Fix BZ-58683

Github user bodewig commented on a diff in the pull request: https://github.com/apache/ant/pull/49#discussion_r155941358 --- Diff: src/main/org/apache/tools/ant/util/SymbolicLinkUtils.java --- @@ -30,6 +30,8 @@ * a symbolic link based on the absent support for them in Java.

[GitHub] ant issue #49: [master branch] - Fix BZ-58683

Github user jaikiran commented on the issue: https://github.com/apache/ant/pull/49 >> Overall I'm in favor of this change and if you want to spend the time on fixing the bugzilla issue in a Java5 friendly way for 1.9.x that would certainly be good - bit not something I'd see as an req

[GitHub] ant pull request #49: [master branch] - Fix BZ-58683

Github user jaikiran commented on a diff in the pull request: https://github.com/apache/ant/pull/49#discussion_r155941213 --- Diff: src/main/org/apache/tools/ant/util/SymbolicLinkUtils.java --- @@ -30,6 +30,8 @@ * a symbolic link based on the absent support for them in Java.

[GitHub] ant pull request #49: [master branch] - Fix BZ-58683

Github user jaikiran commented on a diff in the pull request: https://github.com/apache/ant/pull/49#discussion_r155941155 --- Diff: src/main/org/apache/tools/ant/taskdefs/optional/unix/Symlink.java --- @@ -500,18 +502,12 @@ private void doLink(String res, String lnk) throws BuildE

[GitHub] ant pull request #49: [master branch] - Fix BZ-58683

Github user jaikiran commented on a diff in the pull request: https://github.com/apache/ant/pull/49#discussion_r155941101 --- Diff: src/main/org/apache/tools/ant/taskdefs/optional/unix/Symlink.java --- @@ -448,49 +432,67 @@ private void handleError(String msg) { /**

[GitHub] ant pull request #49: [master branch] - Fix BZ-58683

Github user jaikiran commented on a diff in the pull request: https://github.com/apache/ant/pull/49#discussion_r155941095 --- Diff: src/main/org/apache/tools/ant/taskdefs/optional/unix/Symlink.java --- @@ -207,26 +198,30 @@ public void recreate() throws BuildException {

[GitHub] ant pull request #49: [master branch] - Fix BZ-58683

Github user jaikiran commented on a diff in the pull request: https://github.com/apache/ant/pull/49#discussion_r155941080 --- Diff: manual/Tasks/symlink.html --- @@ -26,7 +26,7 @@ Symlink Description - Manages symbolic links on Unix based platforms. Can be used t

[GitHub] ant pull request #49: [master branch] - Fix BZ-58683

Github user jaikiran commented on a diff in the pull request: https://github.com/apache/ant/pull/49#discussion_r155941076 --- Diff: WHATSNEW --- @@ -27,6 +27,11 @@ Fixed bugs: copy happened to be the same source file (symlinked back to itself). + * Bugzilla