[GitHub] ant pull request #37: [1.9.x branch] BZ-60644 Fix file corruption during cop...

2017-09-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/ant/pull/37 --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org

[GitHub] ant issue #37: [1.9.x branch] BZ-60644 Fix file corruption during copy task

2017-09-28 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant/pull/37 Tests against various JDK versions against Windows and Linux went fine without any regressions. Will go ahead and merge this now. --- --

[GitHub] ant issue #36: Allow faking of zip entry modification times.

2017-09-28 Thread GKFX
Github user GKFX commented on the issue: https://github.com/apache/ant/pull/36 @bodewig Great, I'll have a shot at the parseLenient tests. --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional c

[GitHub] ant pull request #37: [1.9.x branch] BZ-60644 Fix file corruption during cop...

2017-09-28 Thread jaikiran
Github user jaikiran commented on a diff in the pull request: https://github.com/apache/ant/pull/37#discussion_r141594830 --- Diff: src/main/org/apache/tools/ant/util/ResourceUtils.java --- @@ -666,6 +666,14 @@ private static void copyWithFilterSets(final Resource source, final Res

[GitHub] ant pull request #36: Allow faking of zip entry modification times.

2017-09-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/ant/pull/36 --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org

[GitHub] ant issue #37: [1.9.x branch] BZ-60644 Fix file corruption during copy task

2017-09-28 Thread bodewig
Github user bodewig commented on the issue: https://github.com/apache/ant/pull/37 Great change and I agree it should be fixed in the central location. Many thanks! --- - To unsubscribe, e-mail: dev-unsubscr...@ant.a

[GitHub] ant pull request #37: [1.9.x branch] BZ-60644 Fix file corruption during cop...

2017-09-28 Thread bodewig
Github user bodewig commented on a diff in the pull request: https://github.com/apache/ant/pull/37#discussion_r141578555 --- Diff: src/main/org/apache/tools/ant/util/ResourceUtils.java --- @@ -666,6 +666,14 @@ private static void copyWithFilterSets(final Resource source, final Reso

[GitHub] ant issue #36: Allow faking of zip entry modification times.

2017-09-28 Thread bodewig
Github user bodewig commented on the issue: https://github.com/apache/ant/pull/36 Looks great, many thanks! I'll merge it to both branches and add `@since` markers. We'll need to update the manual (probably of zip, jar, war and ear). Also some additional unit tests for `parse