Re: svn commit: r1462931 - in /ant/core/trunk: WHATSNEW manual/Tasks/ear.html manual/Tasks/jar.html manual/Tasks/war.html manual/Tasks/zip.html

2013-03-31 Thread Stefan Bodewig
On 2013-03-31, Jesse Glick wrote: > On 03/31/2013 02:20 PM, Stefan Bodewig wrote: >>> compressing to a temporary buffer perhaps? >> We do so for STORED entries and risk OutOfMemoryExceptions (we could >> throw away the buffer and just count). The performance impact would be >> non-trivial for bi

Re: svn commit: r1462931 - in /ant/core/trunk: WHATSNEW manual/Tasks/ear.html manual/Tasks/jar.html manual/Tasks/war.html manual/Tasks/zip.html

2013-03-31 Thread Jesse Glick
On 03/31/2013 02:20 PM, Stefan Bodewig wrote: compressing to a temporary buffer perhaps? We do so for STORED entries and risk OutOfMemoryExceptions (we could throw away the buffer and just count). The performance impact would be non-trivial for big files, which is what Zip64 really is about.

Re: svn commit: r1462911 - in /ant/core/trunk/src: main/org/apache/tools/ant/taskdefs/Jar.java main/org/apache/tools/ant/taskdefs/Zip.java tests/junit/org/apache/tools/ant/taskdefs/ZipExtraFieldTest.j

2013-03-31 Thread Jesse Glick
On 03/31/2013 02:23 PM, Stefan Bodewig wrote: I must admit I haven't checked whether IntrospectionHelper supports enums, does it do so already? If so, great. Yes, see getEnumSetter. If I want a different string representation like "as-needed" then I still end up writing a mapping class Or

Re: svn commit: r1462911 - in /ant/core/trunk/src: main/org/apache/tools/ant/taskdefs/Jar.java main/org/apache/tools/ant/taskdefs/Zip.java tests/junit/org/apache/tools/ant/taskdefs/ZipExtraFieldTest.j

2013-03-31 Thread Stefan Bodewig
On 2013-03-31, Jesse Glick wrote: > On 03/31/2013 06:22 AM, bode...@apache.org wrote: >>+public static final class Zip64ModeAttribute extends EnumeratedAttribute >>{ > BTW for new code you can simply use an enum. I must admit I haven't checked whether IntrospectionHelper supports enums, do

Re: svn commit: r1462931 - in /ant/core/trunk: WHATSNEW manual/Tasks/ear.html manual/Tasks/jar.html manual/Tasks/war.html manual/Tasks/zip.html

2013-03-31 Thread Stefan Bodewig
On 2013-03-31, Jesse Glick wrote: > On 03/31/2013 07:24 AM, bode...@apache.org wrote: >>> When Ant writes compressed entries into the archive it creates it >>> doesn't know the compressed size of an entry before it has been >>> written. Unfortunately the decision whether a Zip64 extra field >>>

Re: svn commit: r1462931 - in /ant/core/trunk: WHATSNEW manual/Tasks/ear.html manual/Tasks/jar.html manual/Tasks/war.html manual/Tasks/zip.html

2013-03-31 Thread Jesse Glick
On 03/31/2013 07:24 AM, bode...@apache.org wrote: +When Ant writes compressed entries into the archive it creates it + doesn't know the compressed size of an entry before it has been + written. Unfortunately the decision whether a Zip64 extra field + will be written has to be made before writ

Re: svn commit: r1462911 - in /ant/core/trunk/src: main/org/apache/tools/ant/taskdefs/Jar.java main/org/apache/tools/ant/taskdefs/Zip.java tests/junit/org/apache/tools/ant/taskdefs/ZipExtraFieldTest.j

2013-03-31 Thread Jesse Glick
On 03/31/2013 06:22 AM, bode...@apache.org wrote: +public static final class Zip64ModeAttribute extends EnumeratedAttribute { BTW for new code you can simply use an enum. - To unsubscribe, e-mail: dev-unsubscr...@ant.apach

Re: jarsigner 1.5 and Ant zip

2013-03-31 Thread Stefan Bodewig
On 2012-08-23, Nicolas Lalevée wrote: > java 1.5 doesn't seem to be able to read the jar produced by the jar > task. I tried, with the same content, jaring with the jar command, and > java runs fine. It's been on my TODO list far too long and unfortunately I forgot about it when Antoine called fo

Bug report for Ant [2013/03/31]

2013-03-31 Thread bugzilla
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned