Re: deprecations

2012-08-21 Thread Matt Benson
Hi Peter, So does that mean you would be opposed to removing these deprecated items? Matt On Tue, Aug 21, 2012 at 6:07 PM, Peter Reilly wrote: > The only problem is the there are a lot > of tasks out there in the wild that have not > been compiled in a very long time. (I know > I have uses a n

Re: deprecations

2012-08-21 Thread Peter Reilly
The only problem is the there are a lot of tasks out there in the wild that have not been compiled in a very long time. (I know I have uses a number), These will most likely use the deprecated methods, especially in regard to handling of properties and references. Peter 2012/8/20 Martin Gainty :

Re: File.toURL() and org.apache.tools.ant.launch.Locator.fileToURL(File)

2012-08-21 Thread Jesse Glick
On 08/21/2012 03:13 PM, Nicolas Lalevée wrote: Or is there some code which rely on the broken behavior? Not that I know of. See the various commented-out code blocks and "XXX" comments in this class; it has a long and messy history. I do not know whether the current code successfully works aro

Re: File.toURL() and org.apache.tools.ant.launch.Locator.fileToURL(File)

2012-08-21 Thread Jesse Glick
On 08/21/2012 03:41 PM, Martin Gainty wrote: Make sure you catch IllegalArgumentException - If this URL is not absolute Should never happen in this case. MalformedURLException - If a protocol handler for the URL could not be found, or if some other error occurred while constructing

RE: File.toURL() and org.apache.tools.ant.launch.Locator.fileToURL(File)

2012-08-21 Thread Martin Gainty
Good Evening Nicolas If you can demonstrate the Ant task fails before and then a successful implementation (running the same Testcase) after applying the patch then +1 for implementing the patch Nota Bene:Make sure you catch IllegalArgumentException - If this URL is not absolute MalformedURLE

File.toURL() and org.apache.tools.ant.launch.Locator.fileToURL(File)

2012-08-21 Thread Nicolas Lalevée
When trying to setup the build matrix for Ivy, I got hit by the spaces in the paths for the tests. It was due to the well known broken File.toURL(). I have done a broadcast search on Ivy and fix it (it was mainly the unit tests which were broken). So decided to look into IvyDE too and I have fou

Re: deprecations

2012-08-21 Thread Jesse Glick
On 08/20/2012 01:52 PM, Matt Benson wrote: There are lots of methods in Ant's source that have been deprecated since e.g. v1.6. Does anyone object to removing deprecated methods for Ant 1.9? I think OK so long as you are talking about members in the Java API - I guess we are still keeping co