Re: svn commit: r1367306 - /ant/core/trunk/src/main/org/apache/tools/ant/Target.java

2012-07-30 Thread Nicolas Lalevée
It is indeed nicer. committed. Nicolas Le 30 juil. 2012 à 23:48, Nicolas Lalevée a écrit : > > Le 30 juil. 2012 à 23:25, Matt Benson a écrit : > >> Can't this be done more cleanly by internally wrapping all if/unless >> to a Condition instance? > > I haven't thought of that. > Probably it wil

Re: svn commit: r1367306 - /ant/core/trunk/src/main/org/apache/tools/ant/Target.java

2012-07-30 Thread Nicolas Lalevée
Le 30 juil. 2012 à 23:25, Matt Benson a écrit : > Can't this be done more cleanly by internally wrapping all if/unless > to a Condition instance? I haven't thought of that. Probably it will make the test of executability simpler, but not the setter. I will try something. Nicolas > > Matt >

Re: svn commit: r1367306 - /ant/core/trunk/src/main/org/apache/tools/ant/Target.java

2012-07-30 Thread Matt Benson
Can't this be done more cleanly by internally wrapping all if/unless to a Condition instance? Matt On Mon, Jul 30, 2012 at 4:13 PM, wrote: > Author: hibou > Date: Mon Jul 30 21:13:02 2012 > New Revision: 1367306 > > URL: http://svn.apache.org/viewvc?rev=1367306&view=rev > Log: > Allow Condition

Re: Modification of Ant API for AntDSL

2012-07-30 Thread Nicolas Lalevée
I have looked into the actual implementation details, actually I don't need much. So little that I have committed them, it will be easier to review, easier than writing about it in an email. If I can do this with a PropertyHelper, I'll revert and use the non intrusive way. Nicolas Le 28 juil.

Better Diagnostics for Failures

2012-07-30 Thread James Belton
It's been a pet peeve of mine that ant gives so little information when a java class that it's running fails. I hacked my version to print "Java class Error #", which makes it much easier to figure out who broke what, especially in the case where someones code generator silently dies. Since thi