Re: [VOTE] release ant 1.8.0RC1

2010-01-07 Thread Stefan Bodewig
On 2010-01-07, Antoine Levy Lambert wrote: > I do not know as I did not write componentdef. It is mysterious for me > how componentdef works, because I have seen that the Definer class has > a setRestrict method which sets a boolean restrict, but I did not see > where this boolean is read ? It i

Re: [VOTE] release ant 1.8.0RC1

2010-01-07 Thread Stefan Bodewig
On 2010-01-07, Bruce Atherton wrote: > Just minor nits in the release notes, nothing important enough to hold > anything up: > 1. On the line describing , we have: >This method is now used to define conditions, selectors and selectors. > Was the second selectors meant to be filtersets? pr

Re: failing test cases in the build of ant 1.8.0RC1

2010-01-07 Thread Stefan Bodewig
On 2010-01-07, Kevin Jackson wrote: > I get a few Class Cast errors for example: > XMLFragmentTest testNestedText Error > weblogic.apache.xerces.parsers.SecurityConfiguration > cannot be cast to > weblogic.apache.xerces.xni.parser.XMLParserConfiguration One of the weblogic jars contai

Re: [VOTE] release ant 1.8.0RC1

2010-01-07 Thread Antoine Levy Lambert
I had problems to find the tool to generate these release notes. I used to use another web site "txt2html" which did not work for me this time. Let me see if I can remove some empty lines. Antoine I will not have time today to remove the empty lines, and I need to find a better tool. Anyon

Re: [VOTE] release ant 1.8.0RC1

2010-01-07 Thread Antoine Levy Lambert
Maarten Coene wrote: One remark: maybe it's related to my browser, but http://people.apache.org/~antoine/dist/apache-ant-1.8.0RC1/RELEASE-NOTES-1.8.0RC1.html doesn't look very nice and is very annoying to read with all these new/empty lines... I had problems to find the tool to generate t

Re: svn commit: r894462 - in /ant/core/trunk: WHATSNEW docs/manual/CoreTypes/filterchain.html src/main/org/apache/tools/ant/filters/AppendToLines.java src/main/org/apache/tools/ant/types/FilterChain

2010-01-07 Thread Antoine Levy Lambert
Dominique Devienne wrote: On Thu, Jan 7, 2010 at 1:57 PM, Dominique Devienne wrote: On Thu, Jan 7, 2010 at 1:35 PM, Bruce Atherton wrote: While you are undeniably technically right that suffixlines is a better match with prefixlines, which of the three sounds better and is going to be

Re: [VOTE] release ant 1.8.0RC1

2010-01-07 Thread Antoine Levy Lambert
Bruce Atherton wrote: Just minor nits in the release notes, nothing important enough to hold anything up: 1. On the line describing , we have: This method is now used to define conditions, selectors and selectors. Was the second selectors meant to be filtersets? I do not know as I did not

Re: [VOTE] release ant 1.8.0RC1

2010-01-07 Thread Maarten Coene
I only did some functional testing, and everything still worked fine :-) So +1 from me. One remark: maybe it's related to my browser, but http://people.apache.org/~antoine/dist/apache-ant-1.8.0RC1/RELEASE-NOTES-1.8.0RC1.html doesn't look very nice and is very annoying to read with all these new/

Re: 1.8.0RC1

2010-01-07 Thread Antoine Levy Lambert
Uhhm. I did not know that the web site auto updates from svn. I checked in the documentation changes including the release date, because otherwise users complain that the distribution itself is mentioning the previous version of ant as the current version. Is there a way to roll back the web

Re: svn commit: r894462 - in /ant/core/trunk: WHATSNEW docs/manual/CoreTypes/filterchain.html src/main/org/apache/tools/ant/filters/AppendToLines.java src/main/org/apache/tools/ant/types/FilterChain

2010-01-07 Thread Dominique Devienne
On Thu, Jan 7, 2010 at 1:57 PM, Dominique Devienne wrote: > On Thu, Jan 7, 2010 at 1:35 PM, Bruce Atherton wrote: >> While you are undeniably technically right that suffixlines is a better >> match with prefixlines, which of the three sounds better and is going to be >> clearer to users: appendto

Re: svn commit: r894462 - in /ant/core/trunk: WHATSNEW docs/manual/CoreTypes/filterchain.html src/main/org/apache/tools/ant/filters/AppendToLines.java src/main/org/apache/tools/ant/types/FilterChain

2010-01-07 Thread Dominique Devienne
On Thu, Jan 7, 2010 at 1:35 PM, Bruce Atherton wrote: > While you are undeniably technically right that suffixlines is a better > match with prefixlines, which of the three sounds better and is going to be > clearer to users: appendtolines, suffixlines, or postfix lines. header/footer lines? prol

Re: svn commit: r894462 - in /ant/core/trunk: WHATSNEW docs/manual/CoreTypes/filterchain.html src/main/org/apache/tools/ant/filters/AppendToLines.java src/main/org/apache/tools/ant/types/FilterChain.j

2010-01-07 Thread Bruce Atherton
While you are undeniably technically right that suffixlines is a better match with prefixlines, which of the three sounds better and is going to be clearer to users: appendtolines, suffixlines, or postfix lines. If I had to choose one, I'd go with appendtolines, with suffixlines a close second

Re: failing test cases in the build of ant 1.8.0RC1

2010-01-07 Thread Kevin Jackson
Hi, Sorry I didn't include a full stacktrace: SymlinkTest testDelete weblogic.apache.xerces.parsers.SecurityConfiguration cannot be cast to weblogic.apache.xerces.xni.parser.XMLParserConfiguration java.lang.ClassCastException: weblogic.apache.xerces.parsers.SecurityConfiguration cannot be ca

Re: failing test cases in the build of ant 1.8.0RC1

2010-01-07 Thread Kevin Jackson
Hi, I've taken the tagged 1.8RC1 from svn and built against the jars I used for 1.7.1 I get a few Class Cast errors for example: XMLFragmentTest testNestedText Error weblogic.apache.xerces.parsers.SecurityConfiguration cannot be cast to weblogic.apache.xerces.xni.parser.XMLParserConfiguration

Re: [VOTE] release ant 1.8.0RC1

2010-01-07 Thread Bruce Atherton
Just minor nits in the release notes, nothing important enough to hold anything up: 1. On the line describing , we have: This method is now used to define conditions, selectors and selectors. Was the second selectors meant to be filtersets? 2. This is just a style issue: Remove fall-ba

1.8.0RC1

2010-01-07 Thread Kevin Jackson
Hi I hope to test the code tonight on Ubuntu 9.10 + Windows7 ultimate (VirtualBox version) However I note a temporal anomaly on the website: "January 12, 2010 - Ant 1.8.0RC1 Available" Tempus fugit indeed... Kev - To unsubscr

Re: svn commit: r894462 - in /ant/core/trunk: WHATSNEW docs/manual/CoreTypes/filterchain.html src/main/org/apache/tools/ant/filters/AppendToLines.java src/main/org/apache/tools/ant/types/FilterChain.j

2010-01-07 Thread Jesse Glick
Stefan Bodewig wrote: I didn't consult my dictionary. To me it feels as if prefix was a verb in "prefixlines" and I thought "suffix" was not a verb. According to thefreedictionary.com, although the historical derivations are not analogous (surprising to me), both can be used as either noun or

Re: failing test cases in the build of ant 1.8.0RC1

2010-01-07 Thread Antoine Levy Lambert
Stefan Bodewig wrote: On 2010-01-06, Stefan Bodewig wrote: On 2010-01-06, Stefan Bodewig wrote: I'll run the testsute against the binary distribution you've created later today. OK, didn't manage to do it yesterday, did it earlier this morning. Running the tests against

Re: [VOTE] release ant 1.8.0RC1

2010-01-07 Thread Stefan Bodewig
On 2010-01-06, Antoine Levy Lambert wrote: > I have just done a build of ant 1.8.0RC1. The tag in svn is ANT_180_RC1. > The build can be downloaded from > http://people.apache.org/~antoine/dist/apache-ant-1.8.0RC1/ for > evaluation. RAT found two files that I've fixed in trunk, no further issue

Re: failing test cases in the build of ant 1.8.0RC1

2010-01-07 Thread Stefan Bodewig
On 2010-01-06, Antoine Levy Lambert wrote: > Stefan Bodewig wrote: >> On 2010-01-06, Antoine Levy Lambert wrote: >>>[junit] Testcase: >>> testSymbolicLinkUtilsMethods(org.apache.tools.ant.taskdefs.optional.unix.SymlinkTest): >>> FAILED >> I've never seen that, which OS? > Mac OS 10.5.8

Re: failing test cases in the build of ant 1.8.0RC1

2010-01-07 Thread Stefan Bodewig
On 2010-01-06, Stefan Bodewig wrote: > On 2010-01-06, Stefan Bodewig wrote: > I'll run the testsute against the binary distribution you've created > later today. OK, didn't manage to do it yesterday, did it earlier this morning. Running the tests against the jars of the binary distribution (by

Re: 1.8.0RC1: build test

2010-01-07 Thread Stefan Bodewig
On 2010-01-06, wrote: > Downloaded the src-distro, extracted with Winzip. > Classpath not set. > Path=C:\Programme\Perl\bin\;C:\WINNT\system32;C:\WINNT;C:\WINNT\System32 > \Wbem;c:\bin > PATHEXT=.COM;.EXE;.BAT;.CMD;.VBS;.VBE;.JS;.JSE;.WSF;.WSH;.pl > Java: > Java-Home: c:\jdk\142_15 > java versio

Re: svn commit: r894458 - /ant/core/trunk/src/tests/antunit/types/resources/resourcelist-test.xml

2010-01-07 Thread Stefan Bodewig
On 2010-01-06, Jesse Glick wrote: > bode...@apache.org wrote: >>>>> file="${input}/a.txt">jar:file:${ant.home}/lib/ant.jar!/org/apache/tools/ant/antlib.xml > Better to use on ${ant.core.lib} I guess. Good idea, thanks Stefan -