cvs commit: ant/src/main/org/apache/tools/ant/types/selectors AndSelector.java BaseExtendSelector.java BaseSelector.java BaseSelectorContainer.java ContainsRegexpSelector.java ContainsSelector.java DateSelector.java DependSelector.java DepthSelector.java DifferentSelector.java ExtendFileSelector.java ExtendSelector.java FileSelector.java FilenameSelector.java MajoritySelector.java MappingSelector.java NoneSelector.java NotSelector.java OrSelector.java PresentSelector.java SelectSelector.java SelectorContainer.java SelectorScanner.java SelectorUtils.java SizeSelector.java TypeSelector.java

2003-07-04 Thread bruce
bruce 2003/07/04 16:18:50 Modified:src/main/org/apache/tools/ant/types/selectors AndSelector.java BaseExtendSelector.java BaseSelector.java BaseSelectorContainer.java ContainsRegexpSelector.java ContainsSelector.ja

Re: Test Failures

2003-07-04 Thread peter reilly
I think this is due to a change of using an iterator instead of a enumerator. The test code in question was inserting tasks into the current target, and this does not seem to be a good idea. I moved the place where the task is being placed to another target and the test passes. Peter Conor wrote

cvs commit: ant/src/etc/testcases/taskdefs/optional script.xml

2003-07-04 Thread peterreilly
peterreilly2003/07/04 12:20:53 Modified:src/etc/testcases/taskdefs/optional script.xml Log: fix for concurrent access to list exception for rhino testcase The original script added tasks to the current target. This is not a good idea, as an the task list of the target is being wa

Test failures

2003-07-04 Thread Conor MacNeill
I'm currently getting a failure in org.apache.tools.ant.taskdefs.optional.RhinoScriptTest It is a concurrent modification [junit] java.util.ConcurrentModificationException [junit] at java.util.AbstractList$Itr.checkForComodification(AbstractList.java:444) [junit] at java.util

Re: Checkstyle Audit

2003-07-04 Thread Conor MacNeill
On Fri, 4 Jul 2003 08:10 pm, Antoine Levy-Lambert wrote: > Hi Conor, > I am a beotian with xml/xsl. > How do you run the style sheets yourself against the source code of ant ? > Antoine Had to look that one up. The check.xml file contains all the tasks necessary to run the audit. Conor --

cvs commit: ant/src/main/org/apache/tools/ant ComponentHelper.java

2003-07-04 Thread peterreilly
peterreilly2003/07/04 10:00:14 Modified:src/main/org/apache/tools/ant ComponentHelper.java Log: changed for checkstyle Revision ChangesPath 1.17 +82 -53ant/src/main/org/apache/tools/ant/ComponentHelper.java Index: ComponentHelper.java =

DO NOT REPLY [Bug 21346] - Minor Project.listeners opt - avoid cloning

2003-07-04 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bu

DO NOT REPLY [Bug 21296] - Some peephole optimizations

2003-07-04 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bu

DO NOT REPLY [Bug 21346] New: - Minor Project.listeners opt - avoid cloning

2003-07-04 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bu

DO NOT REPLY [Bug 21296] - Some peephole optimizations

2003-07-04 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bu

DO NOT REPLY [Bug 21345] - javacc task to support javacc 3.x

2003-07-04 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bu

cvs commit: ant/src/main/org/apache/tools/ant/filters TokenFilter.java

2003-07-04 Thread peterreilly
peterreilly2003/07/04 09:16:51 Modified:src/main/org/apache/tools/ant/filters TokenFilter.java Log: Fix echeckstyle reported issues Revision ChangesPath 1.8 +281 -154 ant/src/main/org/apache/tools/ant/filters/TokenFilter.java Index: TokenFilter.java ===

DO NOT REPLY [Bug 21345] New: - javacc task to support javacc 3.x

2003-07-04 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bu

DO NOT REPLY [Bug 18007] - stcheckin behavior of rootlocalfolder broken

2003-07-04 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bu

DO NOT REPLY [Bug 18007] - stcheckin behavior of rootlocalfolder broken

2003-07-04 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bu

cvs commit: ant/src/main/org/apache/tools/ant/taskdefs/optional/vss MSVSS.java

2003-07-04 Thread antoine
antoine 2003/07/04 08:51:53 Modified:src/main/org/apache/tools/ant/taskdefs/optional/vss MSVSS.java Log: 1) make sure that the -GTC flag on VSSGET only shows up when a timestamp has been set 2) make sure that if you have label="" you are not going to have -

DO NOT REPLY [Bug 21296] - Some peephole optimizations

2003-07-04 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bu

RE: cvs commit: ant/src/main/org/apache/tools/ant/util/optional W eakishReference12.java

2003-07-04 Thread Dominique Devienne
Technically, it's been created in September 2002 ;-) --DD > -Original Message- > From: Stefan Bodewig [mailto:[EMAIL PROTECTED] > Sent: Friday, July 04, 2003 9:15 AM > To: [EMAIL PROTECTED] > Subject: Re: cvs commit: ant/src/main/org/apache/tools/ant/util/optional > WeakishReference12.java

Re: cvs commit: ant/src/main/org/apache/tools/ant/util/optional WeakishReference12.java

2003-07-04 Thread Stefan Bodewig
On 4 Jul 2003, <[EMAIL PROTECTED]> wrote: > Easy stuff - imports and licence headers Maybe checkstyle is doing too much? > --- SubAnt.java 22 May 2003 07:27:50 - 1.4 > +++ SubAnt.java 4 Jul 2003 14:04:54 - 1.5 > @@ -1,7 +1,7 @@ >/* > * The Apache Softwa

cvs commit: ant/src/main/org/apache/tools/ant/util/optional WeakishReference12.java

2003-07-04 Thread conor
conor 2003/07/04 07:04:56 Modified:src/main/org/apache/tools/ant ComponentHelper.java Project.java TaskContainer.java TypeAdapter.java src/main/org/apache/tools/ant/filters TokenFilter.java src/main/org/apache/tools/ant/helper Proje

cvs commit: ant/src/main/org/apache/tools/ant/util FileUtils.java

2003-07-04 Thread conor
conor 2003/07/04 06:22:43 Modified:src/main/org/apache/tools/ant/util FileUtils.java Log: Remove double-check pattern. Revision ChangesPath 1.46 +29 -24ant/src/main/org/apache/tools/ant/util/FileUtils.java Index: FileUtils.java ==

cvs commit: ant/src/main/org/apache/tools/tar TarEntry.java

2003-07-04 Thread conor
conor 2003/07/04 06:03:38 Modified:.check.xml src/etc/checkstyle checkstyle-config src/main/org/apache/tools/ant/taskdefs CVSPass.java src/main/org/apache/tools/ant/taskdefs/optional/extension Specification.ja

Re: Checkstyle Audit

2003-07-04 Thread Antoine Levy-Lambert
It sounds good. I wish I would know something about Gump to be able to help. Antoine - Original Message - From: "Conor MacNeill" <[EMAIL PROTECTED]> To: "Ant Developers List" <[EMAIL PROTECTED]> Sent: Friday, July 04, 2003 12:23 PM Subject: Re: Checkstyle Audit > On Fri, 4 Jul 2003 05:32

Re: Checkstyle Audit

2003-07-04 Thread Stefan Bodewig
On 04 Jul 2003, peter reilly <[EMAIL PROTECTED]> wrote: > I am surprised you do not see the tooltips I do now - and I'm no longer surprised. I must have disabled tooltips some time ago, can't remember why and when. Sorry for the noise Stefan ---

Re: Checkstyle Audit

2003-07-04 Thread peter reilly
I am surprised you do not see the tooltips The mozilla page http://www.mozilla.org/docs/web-developer/faq.html makes a little song and dance over suporting tooltips for the title attribute. Peter On Fri, 2003-07-04 at 12:50, Stefan Bodewig wrote: > On Fri, 4 Jul 2003, Conor MacNeill <[EMAIL PROTEC

Re: Checkstyle Audit

2003-07-04 Thread Stefan Bodewig
On Fri, 4 Jul 2003, Conor MacNeill <[EMAIL PROTECTED]> wrote: > The pages validate by w3c.org so maybe a bug in Mozilla 1.4? I don't think that the W3C tests whether the title attribute generates a tooltip 8-) Peter says that it works for him, which is strange. I'll simply accept it as an incon

cvs commit: ant/proposal/sandbox/antlib/src/testcases/org/apache/ant/contrib Case.java

2003-07-04 Thread antoine
antoine 2003/07/04 04:46:11 Removed: proposal/sandbox/antlib .cvsignore README build.xml proposal/sandbox/antlib/docs/manual/CoreTasks antjar.html antlib.html proposal/sandbox/antlib/src/main/org/apache/tools/ant

Re: Checkstyle Audit

2003-07-04 Thread Conor MacNeill
On Fri, 4 Jul 2003 08:51 pm, Stefan Bodewig wrote: > On Fri, 4 Jul 2003, Conor MacNeill <[EMAIL PROTECTED]> > > wrote: > > Works on Mozilla 1.2.1 on Linux :-( It is just a title attribute in > > an anchor with no href. > > It seems as if the href was required for it to work in 1.4. > The pages val

cvs commit: ant/xdocs/projects/antlib antlib_classloaders.xml antlib_contract.xml antlib_descriptors.xml antlib_namespaces.xml antlib_roadmap.xml index.xml roles.xml

2003-07-04 Thread antoine
antoine 2003/07/04 04:38:14 Removed: xdocs/projects/antlib antlib_classloaders.xml antlib_contract.xml antlib_descriptors.xml antlib_namespaces.xml antlib_roadmap.xml index.xml roles.xml Log: Remove obsolete docu

cvs commit: ant/src/main/org/apache/tools/ant/taskdefs/optional/extension Extension.java

2003-07-04 Thread conor
conor 2003/07/04 04:36:32 Modified:.check.xml src/etc/checkstyle checkstyle-config src/main/org/apache/tools/ant/taskdefs/optional/extension Extension.java Log: Fix up style errors Revision ChangesPath 1.7

Re: Checkstyle Audit

2003-07-04 Thread peter reilly
I just downloaded mozilla 1.4, and the tooltips work fine on Linux. Peter On Fri, 2003-07-04 at 11:51, Stefan Bodewig wrote: > On Fri, 4 Jul 2003, Conor MacNeill <[EMAIL PROTECTED]> > wrote: > > > Works on Mozilla 1.2.1 on Linux :-( It is just a title attribute in > > an anchor with no href. > >

Re: Checkstyle Audit

2003-07-04 Thread Antoine Levy-Lambert
Hi Conor, I am a beotian with xml/xsl. How do you run the style sheets yourself against the source code of ant ? Antoine - Original Message - From: "Conor MacNeill" <[EMAIL PROTECTED]> To: <[EMAIL PROTECTED]> Sent: Thursday, July 03, 2003 4:26 PM Subject: Checkstyle Audit > I've done a ch

Re: Checkstyle Audit

2003-07-04 Thread Stefan Bodewig
On Fri, 4 Jul 2003, Conor MacNeill <[EMAIL PROTECTED]> wrote: > Works on Mozilla 1.2.1 on Linux :-( It is just a title attribute in > an anchor with no href. It seems as if the href was required for it to work in 1.4. Stefan -

Re: Checkstyle Audit

2003-07-04 Thread Conor MacNeill
On Fri, 4 Jul 2003 08:26 pm, peter reilly wrote: > If that is done, the java-docs should also be included. > > In any case, it is easy to run the check locally (once > one figures out that ant -f check.xml checkstyle needs > to be run before ant -f check.xml ;-) > Peter > :-) I just did that while

Re: Checkstyle Audit

2003-07-04 Thread Conor MacNeill
On Fri, 4 Jul 2003 08:23 pm, Stefan Bodewig wrote: > On Fri, 4 Jul 2003, Conor MacNeill <[EMAIL PROTECTED]> > > wrote: > > If you hover over a line in the detail report it will show which > > checkstyle module triggered the report. > > Doesn't seem to work for Mozilla 1.4 on Linux. > Works on Mozi

AW: Checkstyle Audit

2003-07-04 Thread Jan . Materne
> > It's ad-hoc at the moment. What I would like is to create > an ant-site or > > ant-reports project in Gump and run it nightly from there. > It would need more > > work on the HTML generation from the generated xdocs. It could also > > incorporate the xdocs manual generation. We may need to

Re: Checkstyle Audit

2003-07-04 Thread Stefan Bodewig
On Fri, 4 Jul 2003, Conor MacNeill <[EMAIL PROTECTED]> wrote: > If you hover over a line in the detail report it will show which > checkstyle module triggered the report. Doesn't seem to work for Mozilla 1.4 on Linux. Stefan -

Re: Checkstyle Audit

2003-07-04 Thread peter reilly
On Fri, 2003-07-04 at 11:23, Conor MacNeill wrote: > On Fri, 4 Jul 2003 05:32 pm, Antoine Levy-Lambert wrote: > > Hi Conor, > > > > actually, it might be even better if the pages were generated by a cron job > > running daily, or even better, if a kind of cvs commit daemon would > > regenerate the

Re: Checkstyle Audit

2003-07-04 Thread Conor MacNeill
On Fri, 4 Jul 2003 05:32 pm, Antoine Levy-Lambert wrote: > Hi Conor, > > actually, it might be even better if the pages were generated by a cron job > running daily, or even better, if a kind of cvs commit daemon would > regenerate the pages corresponding to each changed source file. > It's ad-hoc

DO NOT REPLY [Bug 21296] - Some peephole optimizations

2003-07-04 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bu

cvs commit: ant/src/main/org/apache/tools/ant/taskdefs Definer.java

2003-07-04 Thread peterreilly
peterreilly2003/07/04 02:53:08 Modified:src/main/org/apache/tools/ant/taskdefs Definer.java Log: Use getProject() instead of the project field Revision ChangesPath 1.34 +1 -1 ant/src/main/org/apache/tools/ant/taskdefs/Definer.java Index: Definer.java

cvs commit: ant/src/main/org/apache/tools/ant/taskdefs Definer.java

2003-07-04 Thread peterreilly
peterreilly2003/07/04 02:35:31 Modified:src/main/org/apache/tools/ant AntTypeDefinition.java ComponentHelper.java src/main/org/apache/tools/ant/taskdefs Definer.java Log: Remove cloning of AntTypeDefinition when creating a sub-project PR: 2129

Re: cvs commit: ant/src/main/org/apache/tools/ant/taskdefs Definer.java

2003-07-04 Thread peter reilly
Yep, However it is not used at the moment, and it got placed in by accident in the first place. Peter On Fri, 2003-07-04 at 10:01, Stefan Bodewig wrote: > This also remove the format attribute, won't we need that for XML > style task definitions to come? > > Stefan > > --

Re: cvs commit: ant/src/main/org/apache/tools/ant/taskdefs Definer.java

2003-07-04 Thread Stefan Bodewig
This also remove the format attribute, won't we need that for XML style task definitions to come? Stefan - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]

cvs commit: ant/src/main/org/apache/tools/ant RuntimeConfigurable.java UnknownElement.java

2003-07-04 Thread bodewig
bodewig 2003/07/04 01:52:44 Modified:src/main/org/apache/tools/ant RuntimeConfigurable.java UnknownElement.java Log: Indentation changes Revision ChangesPath 1.37 +15 -15 ant/src/main/org/apache/tools/ant/RuntimeConfigurable.java Inde

cvs commit: ant/src/main/org/apache/tools/ant/taskdefs Definer.java

2003-07-04 Thread peterreilly
peterreilly2003/07/04 01:48:19 Modified:src/main/org/apache/tools/ant/taskdefs Definer.java Log: clean up to pass checkstyle Revision ChangesPath 1.32 +131 -42 ant/src/main/org/apache/tools/ant/taskdefs/Definer.java Index: Definer.java ==

DO NOT REPLY [Bug 21296] - Some peephole optimizations

2003-07-04 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bu

cvs commit: ant/src/main/org/apache/tools/ant RuntimeConfigurable.java Target.java UnknownElement.java

2003-07-04 Thread bodewig
bodewig 2003/07/04 01:44:50 Modified:src/main/org/apache/tools/ant RuntimeConfigurable.java Target.java UnknownElement.java Log: Reduce memory consumption by using lazy initialization. Speed things up a little by using unsynchronized collections. PR: 21296

cvs commit: ant/src/main/org/apache/tools/ant/types/selectors SelectorUtils.java

2003-07-04 Thread bodewig
bodewig 2003/07/04 01:43:39 Modified:src/main/org/apache/tools/ant/types/selectors SelectorUtils.java Log: Speed up Path tokeinzation. PR: 21296 Revision ChangesPath 1.10 +58 -20 ant/src/main/org/apache/tools/ant/types/selectors/Selector

cvs commit: ant/src/main/org/apache/tools/ant AntTypeDefinition.java

2003-07-04 Thread peterreilly
peterreilly2003/07/04 01:15:43 Modified:src/main/org/apache/tools/ant AntTypeDefinition.java Log: clean up to pass checkstyle Revision ChangesPath 1.2 +45 -26ant/src/main/org/apache/tools/ant/AntTypeDefinition.java Index: AntTypeDefinition.java ==

Re: Checkstyle Audit

2003-07-04 Thread Antoine Levy-Lambert
Hi Conor, actually, it might be even better if the pages were generated by a cron job running daily, or even better, if a kind of cvs commit daemon would regenerate the pages corresponding to each changed source file. Cheers, Antoine - Original Message - From: "Conor MacNeill" <[EMAIL PR

DO NOT REPLY [Bug 21196] - enhance to load properties from a file

2003-07-04 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bu

DO NOT REPLY [Bug 21228] - sql-task: whitespace after jdbc driver name gives a classloader exception

2003-07-04 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bu

DO NOT REPLY [Bug 21296] - Some peephole optimizations

2003-07-04 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bu

DO NOT REPLY [Bug 21320] - Copy task ignores all but first file returned by FileNameMapper

2003-07-04 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bu

DO NOT REPLY [Bug 21315] - Jar Update Gives Error

2003-07-04 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bu

AW: [Fwd: XSLT task question]

2003-07-04 Thread Jan . Materne
But there is a problem: In which order the XSL files will be processed? I would be careful using filesets for specifying the xsl files. Maybe more [Fwd: XSLT task question]
I'm very new to this whole process and am not really sure how it all works. So I'll just throw this out at you all and see what you think. A few weeks ago I asked the attached question on the users list. I am going to have to build this anyway. So I am wondering if you think the general Ant commun