Re: Checkstyle Audit

2003-07-03 Thread Conor MacNeill
On Fri, 4 Jul 2003 01:15 am, peter reilly wrote: > Excellent work. > I have a problem with three rules: > >major: The "DesignForExtensionCheck" seems a bit silly. >minor: The "LeftCurlyCheck" is against my in-house rule that > if there is a multi line condition, the { should be >

Re: CVS Problem failed to create lock directory for `/home/cvs' (/home/cvs/#cvs.lock)

2003-07-03 Thread Conor MacNeill
On Fri, 4 Jul 2003 08:06 am, Antoine Levy-Lambert wrote: > Anything wrong tonight ? > I've just done an update - seems OK to me. Conor - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTE

RE: CVS Problem failed to create lock directory for `/home/cvs' ( /home/cvs/#cvs.lock)

2003-07-03 Thread Anderson, Robert H - MWT
Check the permission on /home/cvs. You will need write access to that directory on the server. -Rob Anderson -Original Message- From: Antoine Levy-Lambert [mailto:[EMAIL PROTECTED] Sent: Thursday, July 03, 2003 3:06 PM To: Ant Developers List Subject: CVS Problem failed to create lock d

CVS Problem failed to create lock directory for `/home/cvs' (/home/cvs/#cvs.lock)

2003-07-03 Thread Antoine Levy-Lambert
I am experiencing the following : $ nohup cvs update -dP . Sending output to nohup.out $ tail -f nohup.out cvs server: Updating . cvs server: failed to create lock directory for `/home/cvs' (/home/cvs/#cvs.lock): Permission denied cvs server: failed to obtain dir lock in repository `/home/c

DO NOT REPLY [Bug 21298] - Nested websphere element for ejbjar does not support spaces in file name.

2003-07-03 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bu

cvs commit: ant WHATSNEW

2003-07-03 Thread antoine
antoine 2003/07/03 14:48:43 Modified:.WHATSNEW Log: Add solution of PR 21298 PR: 21298 Revision ChangesPath 1.451 +3 -0 ant/WHATSNEW Index: WHATSNEW === RCS file: /home/cvs/ant/WHA

cvs commit: ant/src/main/org/apache/tools/ant/taskdefs/optional/ejb WebsphereDeploymentTool.java

2003-07-03 Thread antoine
antoine 2003/07/03 14:48:07 Modified:src/main/org/apache/tools/ant/taskdefs/optional/ejb WebsphereDeploymentTool.java Log: Nested websphere element for ejbjar does not support spaces in file name. This commit addresses this issue PR: 21298 Submitted by:

DO NOT REPLY [Bug 21320] - Copy task ignores all but first file returned by FileNameMapper

2003-07-03 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bu

DO NOT REPLY [Bug 21316] - [PATCH] eliminate most checkstyle errors in symlink.java

2003-07-03 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bu

DO NOT REPLY [Bug 21298] - Nested websphere element for ejbjar does not support spaces in file name.

2003-07-03 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bu

cvs commit: ant/src/main/org/apache/tools/ant/taskdefs/optional/unix Chgrp.java AbstractAccessTask.java Chown.java

2003-07-03 Thread antoine
antoine 2003/07/03 13:56:16 Modified:src/main/org/apache/tools/ant/taskdefs/optional/unix Chgrp.java AbstractAccessTask.java Chown.java Log: checkstyle fixes PR: 21319 Submitted by: Patrick G. Heck (gus dot heck at olin dot edu) Revision ChangesP

DO NOT REPLY [Bug 21319] - [PATCH] fix checkstyle errors in chmod/chgrp and their superclass

2003-07-03 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bu

DO NOT REPLY [Bug 21316] - [PATCH] eliminate most checkstyle errors in symlink.java

2003-07-03 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bu

cvs commit: ant/src/main/org/apache/tools/ant/taskdefs/optional/unix Symlink.java

2003-07-03 Thread antoine
antoine 2003/07/03 13:47:10 Modified:src/main/org/apache/tools/ant/taskdefs/optional/unix Symlink.java Log: checkstyle fixes PR: 21316 Submitted by: Gus Heck (Gus dot Heck at Olin dot edu) Revision ChangesPath 1.8 +112 -112 ant/src/main

DO NOT REPLY [Bug 21316] - [PATCH] eliminate most checkstyle errors in symlink.java

2003-07-03 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bu

DO NOT REPLY [Bug 21320] - Copy task ignores all but first file returned by FileNameMapper

2003-07-03 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bu

DO NOT REPLY [Bug 21298] - Nested websphere element for ejbjar does not support spaces in file name.

2003-07-03 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bu

DO NOT REPLY [Bug 21320] - Copy task ignores all but first file returned by FileNameMapper

2003-07-03 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bu

DO NOT REPLY [Bug 21320] New: - Copy task ignores all but first file returned by FileNameMapper

2003-07-03 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bu

DO NOT REPLY [Bug 21315] - Jar Update Gives Error

2003-07-03 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bu

DO NOT REPLY [Bug 21319] - [PATCH] fix checkstyle errors in chmod/chgrp and their superclass

2003-07-03 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bu

DO NOT REPLY [Bug 21319] New: - [PATCH] fix checkstyle errors in chmod/chgrp and their superclass

2003-07-03 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bu

DO NOT REPLY [Bug 19897] - Patch to implement the namespaced antlib + other changes

2003-07-03 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bu

DO NOT REPLY [Bug 19897] - Patch to implement the namespaced antlib + other changes

2003-07-03 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bu

DO NOT REPLY [Bug 21315] - Jar Update Gives Error

2003-07-03 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bu

DO NOT REPLY [Bug 21316] - [PATCH] eliminate most checkstyle errors in symlink.java

2003-07-03 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bu

DO NOT REPLY [Bug 21316] New: - [PATCH] eliminate most checkstyle errors in symlink.java

2003-07-03 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bu

DO NOT REPLY [Bug 21315] New: - Jar Update Gives Error

2003-07-03 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bu

Re: Checkstyle Audit

2003-07-03 Thread Gus Heck
minor: "RedundantThrowsCheck: It complains about BuildException. So is it prefered to eliminate the throws BuildException? or keep it? I'm willing to fix my code if I know what is actually desired here. Gus - To unsubscribe, e

Re: Checkstyle Audit

2003-07-03 Thread peter reilly
I know ... Ah well, Peter On Thu, 2003-07-03 at 16:30, Stefan Bodewig wrote: > On 03 Jul 2003, peter reilly <[EMAIL PROTECTED]> wrote: > > >minor: The "LeftCurlyCheck" is against my in-house rule that > > if there is a multi line condition, the { should be > > on a separa

cvs commit: ant/src/main/org/apache/tools/ant/types ZipFileSet.java ZipScanner.java

2003-07-03 Thread bodewig
bodewig 2003/07/03 08:43:09 Modified:src/main/org/apache/tools/ant/taskdefs Zip.java src/main/org/apache/tools/ant/types ZipFileSet.java ZipScanner.java Log: Base and on new ZipFile code. This happens mainly for two reasons: * preser

cvs commit: ant/src/main/org/apache/tools/zip ZipEntry.java ZipFile.java

2003-07-03 Thread bodewig
bodewig 2003/07/03 08:38:40 Modified:src/main/org/apache/tools/zip ZipEntry.java ZipFile.java Log: Improve algorithm that searches for the central directory - don't get fooled by signatures appearing inside payload. Revision ChangesPath 1.11 +2 -2 ant/src/main/

Re: Checkstyle Audit

2003-07-03 Thread Stefan Bodewig
On 03 Jul 2003, peter reilly <[EMAIL PROTECTED]> wrote: >minor: The "LeftCurlyCheck" is against my in-house rule that > if there is a multi line condition, the { should be > on a separate line - but I can live the rule. You inhouse rule is against Ant's coding style, which

Re: Checkstyle Audit

2003-07-03 Thread peter reilly
Excellent work. I have a problem with three rules: major: The "DesignForExtensionCheck" seems a bit silly. minor: The "LeftCurlyCheck" is against my in-house rule that if there is a multi line condition, the { should be on a separate line - but I can live the rule. min

cvs commit: ant/src/main/org/apache/tools/zip ZipEntry.java

2003-07-03 Thread bodewig
bodewig 2003/07/03 08:00:36 Modified:src/main/org/apache/tools/zip ZipEntry.java Log: Need to override isDirectory for situations where setName has been called Revision ChangesPath 1.10 +17 -1 ant/src/main/org/apache/tools/zip/ZipEntry.java Index: ZipEntry.j

cvs commit: ant/src/main/org/apache/tools/zip ZipFile.java

2003-07-03 Thread bodewig
bodewig 2003/07/03 07:59:59 Modified:src/main/org/apache/tools/zip ZipFile.java Log: Calendar.HOUR is different from Calendar.HOUR_OF_DAY Revision ChangesPath 1.3 +2 -2 ant/src/main/org/apache/tools/zip/ZipFile.java Index: ZipFile.java ==

Re: New Laucher

2003-07-03 Thread Conor MacNeill
On Thu, 3 Jul 2003 11:16 pm, Stefan Bodewig wrote: > > It's JDK 1.1 legacy as far as I'm concerned and could those be swapped > against the commented Axis' code. > OK, let's do that > > Looking at the top of JavaURLConnection's javadocs, simply stripping > the leading "jar:" and everything after

Checkstyle Audit

2003-07-03 Thread Conor MacNeill
I've done a checkstyle audit with the new xdoc generating stylesheets and uploaded this to the server http://ant.apache.org/reports/checkstyle/ It's not linked into the rest of the site (nor is it in CVS). It's mainly just for interest at the moment. It does show which files are good candidates

cvs commit: ant/src/etc/checkstyle RequiredHeader.txt checkstyle-config checkstyle-frames.xsl checkstyle-text.xsl checkstyle-xdoc.xsl

2003-07-03 Thread conor
conor 2003/07/03 06:59:51 Modified:.check.xml Added: src/etc/checkstyle RequiredHeader.txt checkstyle-config checkstyle-frames.xsl checkstyle-text.xsl checkstyle-xdoc.xsl Removed: src/etc RequiredHeader.txt checksty

DO NOT REPLY [Bug 21308] New: - looses stored permissions when you update existing archive

2003-07-03 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bu

cvs commit: ant/src/etc/checkstyle - New directory

2003-07-03 Thread conor
conor 2003/07/03 06:21:15 ant/src/etc/checkstyle - New directory - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]

Re: New Laucher

2003-07-03 Thread Stefan Bodewig
On Tue, 1 Jul 2003, Conor MacNeill <[EMAIL PROTECTED]> wrote: > On Tue, 1 Jul 2003 10:02 pm, Stefan Bodewig wrote: >> The only thing I've stumbled over for now is the almost duplicate >> code of Locator#getClassLocationURL and >> oata.util.LoaderUtils#getClassSource > > I wanted to keep the depe

DO NOT REPLY [Bug 10504] - encoding support of unzip task

2003-07-03 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bu

cvs commit: ant/src/testcases/org/apache/tools/ant/taskdefs UntarTest.java UnzipTest.java

2003-07-03 Thread bodewig
bodewig 2003/07/03 06:02:01 Modified:.WHATSNEW docs/manual/CoreTasks unzip.html src/etc/testcases/taskdefs untar.xml unzip.xml src/main/org/apache/tools/ant/taskdefs Expand.java Untar.java src/tes

DO NOT REPLY [Bug 10504] - encoding support of unzip task

2003-07-03 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bu

cvs commit: ant/xdocs/stylesheets project.xml

2003-07-03 Thread bodewig
bodewig 2003/07/03 01:37:19 Modified:docs antnews.html bindownload.html bylaws.html contributors.html cvs.html external.html faq.html index.html legal.html license.html mail.html mission.html problems.html projec

cvs commit: ant/docs bylaws.html faq.html problems.html projects.html

2003-07-03 Thread bodewig
bodewig 2003/07/03 01:33:54 Modified:docs bylaws.html faq.html problems.html projects.html Log: Strange whitespace changes after regenerating the site Revision ChangesPath 1.2 +3 -3 ant/docs/bylaws.html Index: bylaws.html

cvs commit: ant/src/testcases/org/apache/tools/ant/taskdefs UnzipTest.java

2003-07-03 Thread bodewig
bodewig 2003/07/03 01:30:12 Modified:src/main/org/apache/tools/ant/taskdefs Expand.java src/main/org/apache/tools/zip ZipFile.java src/testcases/org/apache/tools/ant/taskdefs UnzipTest.java Log: Finish implementation of ZipFile, use it in Expand (AKA ).

DO NOT REPLY [Bug 21296] - Some peephole optimizations

2003-07-03 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bu

Re: [JAKARTA NEWSLETTER DRAFT] News on 'Apache Ant' from May to June, 2003

2003-07-03 Thread Conor MacNeill
On Thu, 3 Jul 2003 04:26 pm, Tetsuya Kitahata wrote: > If anyone want to add more comments, please go to > http://nagoya.apache.org/wiki/apachewiki.cgi?JakartaNewsletterDrafts/Issue9 > and fill in up what you want to append. > I've added to the general blurb. Conor ---

Re: [JAKARTA NEWSLETTER DRAFT] News on 'Apache Ant' from May to June, 2003

2003-07-03 Thread Tetsuya Kitahata
On Wed, 02 Jul 2003 16:26:21 -0700 (Subject: Re: [JAKARTA NEWSLETTER DRAFT] News on 'Apache Ant' from May to June, 2003) Steve Loughran <[EMAIL PROTECTED]> wrote: > [EMAIL PROTECTED] wrote: > > Dear Apache Ant Development Team, > > (http://ant.apache.org/) > > > > We are now preparing the 'Jak

DO NOT REPLY [Bug 21298] New: - Nested websphere element for ejbjar does not support spaces in file name.

2003-07-03 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bu