Re: [Lazy Concensus] Naming tweak in Deadlines table

2025-05-26 Thread Kalyan Reddy
Thanks Jens. In light of this, I'm proposing to rename it to "deadline_at" . I've updated the PR as well. But "deadline_time" also sounds good. We can go with that as well. I can update PR with what we agree here. On 2025/05/27 01:47:57 Wei Lee wrote: > Not sure whether "deadline.deadline_time"

Re: [Lazy Concensus] Naming tweak in Deadlines table

2025-05-26 Thread Wei Lee
Not sure whether "deadline.deadline_time" is an ok idea 🤔 I also worry about what Jens said. Best, Wei > On May 27, 2025, at 4:26 AM, Jens Scheffler > wrote: > > Hi Denis, > > from point of content of the name matching to the meaning I agree - but I > have doubts because the column name con

Re: [DISCUSS] Keycloak provider

2025-05-26 Thread Vincent Beck
Thanks for your feedbacks. I went ahead and created a PR to create the new provider: https://github.com/apache/airflow/pull/51081 On 2025/05/21 15:44:44 Buğra Öztürk wrote: > I think having a separate Keycloak auth manager would be amazing. Thanks > for the discussion and PoC work Vincent! > > O

[Lazy Concensus] Naming tweak in Deadlines table

2025-05-26 Thread Ferruzzi, Dennis
rawwar is working on some front-end stuff for the Deadlines feature and has a suggestion to rename the database field which holds the calculated timestamp from deadline.deadline to deadline.time. This seems reasonable to me and slightly less confusing, but I wanted to throw it out there for laz

[DISCUSS] Deadlines default interval

2025-05-26 Thread Ferruzzi, Dennis
Hey folks. TLDR first, more context below. rawwar has suggested that the interval on a new DeadlineAlert should default to 0. I can see a usecase for that but I don't feel like that should be the default. What say you? For some context, as of right now the interval is not optional and does n

Re: [Lazy Concensus] Naming tweak in Deadlines table

2025-05-26 Thread Jens Scheffler
Hi Denis, from point of content of the name matching to the meaning I agree - but I have doubts because the column name conflicts with the SQL type that has the same same. As we use ORM this is mostly fine but other logic running SQL on the DB might get into conflict if column name "time" is