Re: [VOTE] March 2025 PR of the Month

2025-03-25 Thread Amogh Desai
Not to disregard any PRs in the list, but I'd like to self-nominate one of my PRs for PR of the month:: https://github.com/apache/airflow/pull/47339. XComs as we know is a simple concept but when it comes to internals -- covering the model, serialization, deserialization, forward compatibility wit

Re: [VOTE] March 2025 PR of the Month

2025-03-25 Thread Amogh Desai
Missed a point. Not to mention the tons of things it broke :) It took almost 2-3 days to get the tests working, compat, providers etc :) Thanks to Ash for patiently reviewing it!! Thanks & Regards, Amogh Desai On Tue, 25 Mar 2025 at 5:20 PM, Amogh Desai wrote: > Not to disregard any PRs in

Re: [VOTE] March 2025 PR of the Month

2025-03-25 Thread Elad Kalif
I vote for https://github.com/apache/airflow/pull/46056 : Update task lifecycle diagram for missing states First time contributor that started with a change of image in our docs, during review we suggested a much more reseliate approach (diagram as code). The author took the challenge and made it

Removing unlimited parallelism

2025-03-25 Thread Jens Scheffler
Hi Dev Community, I just want to raise awareness - to be announced - that shortly before RC of Airflow 3.0.0 - as I was crawling through the tickets I wanted to close some task that we discussed about: Unlimited parallelism. This was configurable in the past and went a bit back- and forth. Plea

Re: [VOTE] March 2025 PR of the Month

2025-03-25 Thread Jens Scheffler
+1 for 46056 On 25.03.25 16:05, Ankit Chaurasia wrote: +1 forhttps://github.com/apache/airflow/pull/45300 *Ankit Chaurasia* On Tue, Mar 25, 2025 at 8:36 PM Bas Harenslak wrote: +1 for 47320 On 25 Mar 2025, at 15:14, Pierre Jeambrun wrote: +1 forhttps://github.com/apache/airflow/pull/

Re: [DISCUSS] Decisions made on devlist

2025-03-25 Thread Ash Berlin-Taylor
> On 23 Mar 2025, at 03:44, Jarek Potiuk wrote: > > The thread here was sparked with a slack discussion where TP > commented essentially "we should change our layout of folder, I do not like > the lack of consistency" - in a random slack conversation, that many of us > could have missed. And I

Re: [VOTE] March 2025 PR of the Month

2025-03-25 Thread Wei Lee
My vote goes to #47433. It unblocks numerous AIP-84 related PRs. Best, Wei > On Mar 25, 2025, at 7:52 PM, Amogh Desai wrote: > > Missed a point. > > Not to mention the tons of things it broke :) > > It took almost 2-3 days to get the tests working, compat, providers etc :) > > Thanks to Ash

Re: [ANNOUNCEMENT] airflow-core is there (finally!)

2025-03-25 Thread Vincent Beck
I love this script! Thanks Pavan for doing it, that saves me (and I guess many people as well) a lot of time! On 2025/03/25 00:52:13 Jarek Potiuk wrote: > Nice follow up ! > > Thanks to Pavan, we now have a very nice tooling to set up the Airflow > multi-distribution project with PyCharm/Intelli

Re: [DISCUSS] Decisions made on devlist

2025-03-25 Thread Abhishek Bhakat
IMO having the discussion on Github has very helpful for me. That's just the first place we look for. And if been asked on why was "*this particular change*" was made, I can answer it brought up a discussion on the dev list and the community voted on it. In a gist, I don't have a problem with the

Re: Simple auth manager as default auth manager

2025-03-25 Thread Jens Scheffler
Very Cool! > SimpleAuthManager *should not be used in production* ..haha, this is the successor of SequentialExecutor as minimalization On 20.03.25 14:33, Jarek Potiuk wrote: Fantastic! Thanks for all the details Vincent! And long live SimpleAuthManager! J. On Thu, Mar 20, 2025 at 2:17 PM

Re: [DISCUSS] confusing alert re SimpleAuthManager

2025-03-25 Thread Oliveira, Niko
Agreed, I think combining the two will make SAM not so simple. But we should definitely have an open source, easy to acquire option for people to use that has all the bells and whistles that SAM does not have. And KeyCloack is a decent option for this! From: Vin

Re: [ANNOUNCEMENT] airflow-core is there (finally!)

2025-03-25 Thread Jarek Potiuk
Yeah. For a moment I considered this to be candidate for PR of the month - but we have so many candidates! On Tue, Mar 25, 2025 at 2:54 PM Vincent Beck wrote: > I love this script! Thanks Pavan for doing it, that saves me (and I guess > many people as well) a lot of time! > > On 2025/03/25 00:52

Re: [VOTE] March 2025 PR of the Month

2025-03-25 Thread Pierre Jeambrun
+1 for https://github.com/apache/airflow/pull/47433 Hard to choose On Tue, Mar 25, 2025 at 2:40 PM Vincent Beck wrote: > My vote goes for https://github.com/apache/airflow/pull/47432. That was a > major security issue with the way the JWT token was exchanged and it got it > fixed after multiple

Re: [VOTE] March 2025 PR of the Month

2025-03-25 Thread Bas Harenslak
+1 for 47320 > On 25 Mar 2025, at 15:14, Pierre Jeambrun wrote: > > +1 for https://github.com/apache/airflow/pull/47433 > > Hard to choose > > On Tue, Mar 25, 2025 at 2:40 PM Vincent Beck wrote: > >> My vote goes for https://github.com/apache/airflow/pull/47432. That was a >> major security

Re: [DISCUSS] Decisions made on devlist

2025-03-25 Thread Jarek Potiuk
> So I’m not sure what you are actually proposing, since we already do make important decisions on the list, and that discussing the minutia of every decision isn’t practical. I think it's really a question of the impact it has. In this case changing the layout of the repo (as I tried to explain h

Re: [VOTE] March 2025 PR of the Month

2025-03-25 Thread Vincent Beck
My vote goes for https://github.com/apache/airflow/pull/47432. That was a major security issue with the way the JWT token was exchanged and it got it fixed after multiple iterations. But to be honest, there are at least 5 other PRs I'd also like to nominate, it has been a good month :) On 2025

Re: [VOTE] March 2025 PR of the Month

2025-03-25 Thread Ankit Chaurasia
+1 for https://github.com/apache/airflow/pull/45300 *Ankit Chaurasia* On Tue, Mar 25, 2025 at 8:36 PM Bas Harenslak wrote: > +1 for 47320 > > > On 25 Mar 2025, at 15:14, Pierre Jeambrun wrote: > > > > +1 for https://github.com/apache/airflow/pull/47433 > > > > Hard to choose > > > > On Tu

[Meeting Notes] Airflow 3.0 dev call - 20 March 2025

2025-03-25 Thread Vikram Koka
Hey everyone, I updated our meeting notes document in the Airflow wiki to capture the notes from our dev call last week. The link for those notes is here As always, it was wonderfu

Re: [VOTE] March 2025 PR of the Month

2025-03-25 Thread Jarek Potiuk
+1 #47320 - though I think we should have about 10 "PRs of the month" this month :) On Tue, Mar 25, 2025 at 6:04 AM Abhishek Bhakat wrote: > +1 for 47320 > > - Avi > > On Mon, Mar 24, 2025 at 10:57 PM Briana Okyere > wrote: > > > Hey All, > > > > It’s once again time to vote for the PR of the M

Clean up the task context dict

2025-03-25 Thread Tzu-ping Chung
Hi all, There was an issue a while ago proposing to add more values into the context dict.[1] I responded at the time that the proposed values are already available by accessing 'ti' although it’s unclear whether the internals of the variable (which was a concrete SQLAlchemy model TaskInstance