Re: [DISCUSS] Proposal to enhance the PR template

2025-02-22 Thread Wei Lee
Yep, I also think better labeling (and other CI checks) would be a better choice! (if we could and have the bandwidth to do so) Checkboxes often get overlooked, and might need some time to teach all contributors. Take the significant template as an example, I still need to check new newsfragment

Re: [DISCUSS] Proposal to enhance the PR template

2025-02-22 Thread Daniel Standish
RE >I think this small change would significantly improve the confidence in code reviewers during review and also make it easier to track down issues if they arise at a later stage. So, expanding... any time you see a change to airflow/api_fastapi, you are probably making changes to "the interface

Re: [VOTE] Airflow Providers prepared on February 21, 2025

2025-02-22 Thread Amogh Desai
+1 non binding The ones with testing impact: - https://github.com/apache/airflow/pull/46866 - https://github.com/apache/airflow/pull/46860 - https://github.com/apache/airflow/pull/46795 - https://github.com/apache/airflow/pull/46231 (imported and ran a dag with emptyoperator from new path) - https

Re: [DISCUSS] Proposal to enhance the PR template

2025-02-22 Thread Jarek Potiuk
I like much more "fixing" (or upgrading) the labelling scheme rather than checkbox. With changes like that we have to be careful to impact experience of everyone - while improving some "failure" scenario, you also make live of everyone who raises PR and has to learn about those checkboxes, know wha