Re: [Discuss] Airflow 2 to 3 migration rules

2024-11-21 Thread Wei Lee
Hi all, I just updated the rules before #44080 in https://github.com/apache/airflow/issues/41641. I tried to compile the rules as thoroughly as possible, but it would be great if folks could take another look to see if these URLs make sense or if I missed anything. If everything looks good, please

Re: [Discuss] Airflow 2 to 3 migration rules

2024-11-21 Thread Vincent Beck
Hi Wei, Thanks for doing it. Pretty impressive the number of changes we did :) Just one clarification though (and sorry if it was mentioned somewhere else), what do you exactly mean by "If everything looks good, please click the checkbox in". Do you mean if the change listed is indeed a breakin

[LAZY CONSENSUS] Use Ruff as the official linter to detect Airflow 3 incompatibilities in user code

2024-11-21 Thread Tzu-ping Chung
Hi all, I am calling a LAZY CONSENSUS to officially anoint Ruff as the tool to implement lint rules that detect potential incompatibilities in existing user code (including DAG files and plugins) that may break in Airflow 3. The rationale is * Ruff provides the best set of features for our nee

Re: [LAZY CONSENSUS] Use Ruff as the official linter to detect Airflow 3 incompatibilities in user code

2024-11-21 Thread Pierre Jeambrun
That's a nice one, looking forward to it :) On Thu, Nov 21, 2024 at 12:55 PM Tzu-ping Chung wrote: > Hi all, > > I am calling a LAZY CONSENSUS to officially anoint Ruff as the tool to > implement lint rules that detect potential incompatibilities in existing > user code (including DAG files and

Re: [LAZY CONSENSUS] Use Ruff as the official linter to detect Airflow 3 incompatibilities in user code

2024-11-21 Thread Julian LaNeve
This is awesome to see - I wrote the first rule in Ruff for Airflow, and it was super easy to do despite not having written any Rust prior. The Ruff maintainers are also incredibly responsive and helpful. I think Airflow’s one of the largest projects they work with, and they have us listed on t

Re: [Discuss] Airflow 2 to 3 migration rules

2024-11-21 Thread Wei Lee
Hi Vincent, Yep, I should have explained it better 🤦‍♂️ What I meant is whether we need to raise a warning through Ruff for that breaking change (see "[LAZY CONSENSUS] Use Ruff as the official linter to detect Airflow 3 incompatibilities in user code” [1]) and whether I list it correctly. For e

Re: [LAZY CONSENSUS] Use Ruff as the official linter to detect Airflow 3 incompatibilities in user code

2024-11-21 Thread Buğra Öztürk
It would be great to see Ruff more. It performs well too over other linters. Plus any time we save during the migration process would be helpful to users. On Fri, Nov 22, 2024 at 1:27 AM Jarek Potiuk wrote: > Agree. Very good direction! > > On Thu, Nov 21, 2024 at 5:00 PM Julian LaNeve > > wrot

Re: [LAZY CONSENSUS] Use Ruff as the official linter to detect Airflow 3 incompatibilities in user code

2024-11-21 Thread Jarek Potiuk
Agree. Very good direction! On Thu, Nov 21, 2024 at 5:00 PM Julian LaNeve wrote: > This is awesome to see - I wrote the first rule in Ruff for Airflow, and > it was super easy to do despite not having written any Rust prior. > > The Ruff maintainers are also incredibly responsive and helpful. I