Re: Two Hard Things: Deadline Alerts Edition

2025-02-25 Thread Daniel Standish
I thought it was planned for 3.1, not necessarily 3.0. In any case, it's just an idea. Let's see how Feruzzi feels about it. Even the generalization is not taken up, perhaps you might look at the suggestion re target event vs reference event. I think it's helpful to think about it that way but,

Re: Two Hard Things: Deadline Alerts Edition

2025-02-25 Thread Ferruzzi, Dennis
Jarek - The Deadlines stuff got voted out of 3.0, I'm hoping to have this for 3.1 now. Ash - Valid comments. "need_by" was mostly just used there for demonstrative purposes, it won't be a user-facing variable. I can certainly change it if you feel one of the other names is easier for Future

Re: Two Hard Things: Deadline Alerts Edition

2025-02-25 Thread Jarek Potiuk
Re: generalization: Nice idea Daniel, but are you sure we can come up (and agree) with a generic enough approach and have it still done for Airflow 3. For me this is a bit YAGNI - and rather than generalising now, it would be better to hash it out, vote and see all the considerations in a new AIP -

Re: Two Hard Things: Deadline Alerts Edition

2025-02-25 Thread Daniel Standish
Thinking about this interface a little bit I have some thoughts to share. I think it might be good to generalize it very slightly to "expectations" so that we can set multiple different kinds of expectations, and not just deadlines. I also thought it might be helpful to make clear what is the ref

Re: Two Hard Things: Deadline Alerts Edition

2025-02-25 Thread Daniel Standish
also... curious can you confirm my understanding of what this means `landing_time = DeadlineReference.DAGRUN_QUEUED + timedelta(hours=1)` does this mean that the expectation will be missed if the *dag run does not complete* within 1 hr of dag run queued time? i.e. is it correct the event of inte

Re: Two Hard Things: Deadline Alerts Edition

2025-02-25 Thread Daniel Standish
or "expected_by" i like expected_by over need_by On Tue, Feb 25, 2025 at 6:26 AM Ash Berlin-Taylor wrote: > Breaking with the herd/answering a question you didn’t even ask > (:evil-grin:) > > How about changing need_by to landing_time, i.e. > > `landing_time = DeadlineReference.DAGRUN_QUEUED + t

Re: Two Hard Things: Deadline Alerts Edition

2025-02-25 Thread Ash Berlin-Taylor
Breaking with the herd/answering a question you didn’t even ask (:evil-grin:) How about changing need_by to landing_time, i.e. `landing_time = DeadlineReference.DAGRUN_QUEUED + timedelta(hours=1)` Or some variation there of - `landed_by` etc. -ash > On 25 Feb 2025, at 05:15, Ankit Chaurasia

Re: Two Hard Things: Deadline Alerts Edition

2025-02-24 Thread Ankit Chaurasia
DeadlineReference +1. Regards, *Ankit Chaurasia* On Tue, 25 Feb 2025 at 10:05, Pavankumar Gopidesu wrote: > +1 `DeadlineReference` > > Regards > Pavan Kumar > > On Tue, Feb 25, 2025, 04:11 Amogh Desai wrote: > > > Late to the party, but I'd vote for `DeadlineReference` too. Concise and

Re: Two Hard Things: Deadline Alerts Edition

2025-02-24 Thread Pavankumar Gopidesu
+1 `DeadlineReference` Regards Pavan Kumar On Tue, Feb 25, 2025, 04:11 Amogh Desai wrote: > Late to the party, but I'd vote for `DeadlineReference` too. Concise and > does the job well. > > Thanks & Regards, > Amogh Desai > > > On Tue, Feb 25, 2025 at 7:56 AM Wei Lee wrote: > > > A bit late t

Re: Two Hard Things: Deadline Alerts Edition

2025-02-24 Thread Amogh Desai
Late to the party, but I'd vote for `DeadlineReference` too. Concise and does the job well. Thanks & Regards, Amogh Desai On Tue, Feb 25, 2025 at 7:56 AM Wei Lee wrote: > A bit late to the party, but DeadlineReference +1. > > Best, > Wei > > > On Feb 25, 2025, at 4:02 AM, Daniel Standish > wr

Re: Two Hard Things: Deadline Alerts Edition

2025-02-24 Thread Wei Lee
A bit late to the party, but DeadlineReference +1. Best, Wei > On Feb 25, 2025, at 4:02 AM, Daniel Standish > wrote: > > Stewing presently thank you :) > > On Mon, Feb 24, 2025 at 11:53 AM Ferruzzi, Dennis > wrote: > >> Alright then. DeadlineReference gets the green light for now! If any

Re: Two Hard Things: Deadline Alerts Edition

2025-02-24 Thread Daniel Standish
Stewing presently thank you :) On Mon, Feb 24, 2025 at 11:53 AM Ferruzzi, Dennis wrote: > Alright then. DeadlineReference gets the green light for now! If anyone > has a suggestion they like more, please feel free to drop it in here. I'm > working on some Ariflow3.0 stuff before I get back t

Re: Two Hard Things: Deadline Alerts Edition

2025-02-24 Thread Ferruzzi, Dennis
Alright then. DeadlineReference gets the green light for now! If anyone has a suggestion they like more, please feel free to drop it in here. I'm working on some Ariflow3.0 stuff before I get back to this, so there's plenty of time before this is set down if anyone wants to stew on it a bit.

Re: Two Hard Things: Deadline Alerts Edition

2025-02-24 Thread Jarek Potiuk
Yep. DaeadlineReference is good . On Mon, Feb 24, 2025 at 8:07 PM Mehta, Shubham wrote: > +1 to DeadlineReference. It is clear and allows flexibility to choose any > reference point. > > shubham > > On 2025-02-24, 10:00 AM, "Ferruzzi, Dennis" LID> wrote: > > >

Re: Two Hard Things: Deadline Alerts Edition

2025-02-24 Thread Mehta, Shubham
+1 to DeadlineReference. It is clear and allows flexibility to choose any reference point. shubham On 2025-02-24, 10:00 AM, "Ferruzzi, Dennis" mailto:ferru...@amazon.com.inva>LID> wrote: CAUTION: This email originated from outside of the organization. Do not click links or open attachments u

Re: Two Hard Things: Deadline Alerts Edition

2025-02-24 Thread Akash Sharma
How about DeadlineStartPoint or DeadlineStartRef? On Mon, 24 Feb, 2025, 23:46 Tzu-ping Chung, wrote: > I like StartsFrom, but “DeadlineStartsFrom” sounds like when the deadline > is. It should have another word in front. > > DeadlineReference sounds reasonable to me. Something like DeadlineBase

Re: Two Hard Things: Deadline Alerts Edition

2025-02-24 Thread Vincent Beck
+1 for reference, it reads well and makes sense to me On 2025/02/24 18:15:02 Tzu-ping Chung wrote: > I like StartsFrom, but “DeadlineStartsFrom” sounds like when the deadline is. > It should have another word in front. > > DeadlineReference sounds reasonable to me. Something like DeadlineBase or

Re: Two Hard Things: Deadline Alerts Edition

2025-02-24 Thread Tzu-ping Chung
I like StartsFrom, but “DeadlineStartsFrom” sounds like when the deadline is. It should have another word in front. DeadlineReference sounds reasonable to me. Something like DeadlineBase or DeadlineBasis could be possible too, although I actually like reference better. I kind of feel DeadlineMe

Re: Two Hard Things: Deadline Alerts Edition

2025-02-24 Thread Jarek Potiuk
Why not `DeadlineStartsFrom` ? On Mon, Feb 24, 2025 at 7:00 PM Ferruzzi, Dennis wrote: > Hey folks. I need to narrow down the name for one of the parameters on > the Deadline Alerts work and I'm fishing for suggestions. > > TLDR:need_by_date = {some existing timestamp} + {a user-defined