Merged.
On Fri, Nov 29, 2024 at 8:31 AM Jarek Potiuk wrote:
> Cool :). Moar fixes :)
>
> On Fri, Nov 29, 2024 at 8:13 AM Pavankumar Gopidesu <
> gopidesupa...@gmail.com> wrote:
>
>> Yes, I agree.
>>
>> I just looked at the ruff , I think we have more to fix in the coming
>> days :)
>>
>> https:/
Cool :). Moar fixes :)
On Fri, Nov 29, 2024 at 8:13 AM Pavankumar Gopidesu
wrote:
> Yes, I agree.
>
> I just looked at the ruff , I think we have more to fix in the coming days
> :)
>
> https://github.com/astral-sh/ruff/pull/14661
>
> https://github.com/astral-sh/ruff/pull/14611
>
> On Fri, Nov
Yes, I agree.
I just looked at the ruff , I think we have more to fix in the coming days :)
https://github.com/astral-sh/ruff/pull/14661
https://github.com/astral-sh/ruff/pull/14611
On Fri, Nov 29, 2024 at 7:06 AM Jarek Potiuk wrote:
>
> Seeing the universal support - I progress with
> https:/
Seeing the universal support - I progress with
https://github.com/apache/airflow/pull/44466 -> Note it's not only for
asserts, there are a number of other places where comparison was not RIGHT
(pun intended)..
On Fri, Nov 29, 2024 at 7:50 AM Pavankumar Gopidesu
wrote:
> +1 agree :)
>
> Regards,
+1 agree :)
Regards,
Pavan
On Fri, Nov 29, 2024, 06:37 Amogh Desai wrote:
> Vote +1 for this, I do. (Sorry couldn't help it)
>
> It's nice that there is some automation to do this. It was always slightly
> annoying to me
> coming from a different programming language background
>
> Thanks & Re
Amazing!
*Ankit Chaurasia*
On Fri, 29 Nov 2024 at 12:16, Amogh Desai wrote:
> Amazing!
>
> This was not an easy task at all.
>
> Thank you to everyone who was involved and special thanks for Pierre for
> your unwavering support!
>
> Thanks & Regards,
> Amogh Desai
>
>
> On Fri, Nov 29, 202
Vote +1 for this, I do. (Sorry couldn't help it)
It's nice that there is some automation to do this. It was always slightly
annoying to me
coming from a different programming language background
Thanks & Regards,
Amogh Desai
On Fri, Nov 29, 2024 at 12:00 PM Shahar Epstein wrote:
> +1 Agree, I
Amazing!
This was not an easy task at all.
Thank you to everyone who was involved and special thanks for Pierre for
your unwavering support!
Thanks & Regards,
Amogh Desai
On Fri, Nov 29, 2024 at 7:32 AM Wei Lee wrote:
> 🙌
>
> > On Nov 29, 2024, at 8:29 AM, Kaxil Naik wrote:
> >
> > Awesome
+1 Agree, I do :-)
On Thu, Nov 28, 2024 at 9:12 PM Jarek Potiuk wrote:
> Hello here,
>
> Following from slack discussion:
> https://apache-airflow.slack.com/archives/C06K9Q5G2UA/p1732816777850809
>
> While responding to https://github.com/apache/airflow/discussions/44455
> (really nice that Astr
Yeah this seems pretty uncontroversial. I assume most of the occurrences
are left over from when we converted to pytest. I tend to fix them as I go,
since pytest expects it this way. Did not know there was automation for it
but that’s great.
On Thu, Nov 28, 2024 at 6:06 PM Wei Lee wrote:
> +1 f
+1 for this!
This is how pytest doc https://docs.pytest.org/en/stable/how-to/assert.html
suggests.
Best,
Wei
> On Nov 29, 2024, at 8:28 AM, Kaxil Naik wrote:
>
> Same as slack, prefer it on right. Right is right 😆
>
> On Thu, 28 Nov 2024 at 23:48, Hussein Awala wrote:
>
>> +1
>>
>> On Fri
🙌
> On Nov 29, 2024, at 8:29 AM, Kaxil Naik wrote:
>
> Awesome stuff, kudos to Pierre and everyone involved 🎉
>
> On Thu, 28 Nov 2024 at 19:08, Pavankumar Gopidesu
> wrote:
>
>> Woohoo 🙌 thank you everyone :)
>>
>> On Thu, Nov 28, 2024, 18:13 Vincent Beck wrote:
>>
>>> HUGE!
>>>
>>> On 2
Awesome stuff, kudos to Pierre and everyone involved 🎉
On Thu, 28 Nov 2024 at 19:08, Pavankumar Gopidesu
wrote:
> Woohoo 🙌 thank you everyone :)
>
> On Thu, Nov 28, 2024, 18:13 Vincent Beck wrote:
>
> > HUGE!
> >
> > On 2024/11/28 17:25:45 Jarek Potiuk wrote:
> > > WOOWOOWOW!
> > >
> > > O
Same as slack, prefer it on right. Right is right 😆
On Thu, 28 Nov 2024 at 23:48, Hussein Awala wrote:
> +1
>
> On Fri, Nov 29, 2024 at 12:28 AM Jarek Potiuk wrote:
>
> > FYI: This is how it will look like when SIM300 is applied:
> > https://github.com/apache/airflow/pull/44466
> >
> > On Thu,
+1
On Fri, Nov 29, 2024 at 12:28 AM Jarek Potiuk wrote:
> FYI: This is how it will look like when SIM300 is applied:
> https://github.com/apache/airflow/pull/44466
>
> On Thu, Nov 28, 2024 at 11:23 PM Jens Scheffler >
> wrote:
>
> > This is nto a vote but still +1 :-D
> >
> > On 28.11.24 22:48,
FYI: This is how it will look like when SIM300 is applied:
https://github.com/apache/airflow/pull/44466
On Thu, Nov 28, 2024 at 11:23 PM Jens Scheffler
wrote:
> This is nto a vote but still +1 :-D
>
> On 28.11.24 22:48, Ash Berlin-Taylor wrote:
> > +10, it’s defence against a problem that is imp
This is nto a vote but still +1 :-D
On 28.11.24 22:48, Ash Berlin-Taylor wrote:
+10, it’s defence against a problem that is impossible in Python, _and_ it’s
counter to how pytest wants it.
On 28 Nov 2024, at 21:46, Ferruzzi, Dennis wrote:
+0.5 LOL I don't particularly care which order t
+10, it’s defence against a problem that is impossible in Python, _and_ it’s
counter to how pytest wants it.
> On 28 Nov 2024, at 21:46, Ferruzzi, Dennis
> wrote:
>
> +0.5 LOL I don't particularly care which order they go in, but I do love
> standardizing the codebase and that IS how pyte
+0.5 LOL I don't particularly care which order they go in, but I do love
standardizing the codebase and that IS how pytest reports it, so I say let's go
for it.
- ferruzzi
From: Jarek Potiuk
Sent: Thursday, November 28, 2024 11:16 AM
To: dev@airflow.apac
OK. And now let the flamewar starts ;)
On Thu, Nov 28, 2024 at 8:11 PM Jarek Potiuk wrote:
> Hello here,
>
> Following from slack discussion:
> https://apache-airflow.slack.com/archives/C06K9Q5G2UA/p1732816777850809
>
> While responding to https://github.com/apache/airflow/discussions/44455
> (r
Hello here,
Following from slack discussion:
https://apache-airflow.slack.com/archives/C06K9Q5G2UA/p1732816777850809
While responding to https://github.com/apache/airflow/discussions/44455
(really nice that Astral people are using Airflow to test new ruff rules) I
noticed that we have a number of
Woohoo 🙌 thank you everyone :)
On Thu, Nov 28, 2024, 18:13 Vincent Beck wrote:
> HUGE!
>
> On 2024/11/28 17:25:45 Jarek Potiuk wrote:
> > WOOWOOWOW!
> >
> > On Thu, Nov 28, 2024 at 6:11 PM Pierre Jeambrun
> > wrote:
> >
> > > Hello all,
> > >
> > > We just completed the migration of the pu
Well done.
- ferruzzi
From: Vincent Beck
Sent: Thursday, November 28, 2024 10:13 AM
To: dev@airflow.apache.org
Subject: RE: [EXT] AIP-84 Public API Migration
CAUTION: This email originated from outside of the organization. Do not click
links or open attachme
HUGE!
On 2024/11/28 17:25:45 Jarek Potiuk wrote:
> WOOWOOWOW!
>
> On Thu, Nov 28, 2024 at 6:11 PM Pierre Jeambrun
> wrote:
>
> > Hello all,
> >
> > We just completed the migration of the public API to the new FastAPI
> > server, closing a big one https://github.com/apache/airflow/issues/423
WOOWOOWOW!
On Thu, Nov 28, 2024 at 6:11 PM Pierre Jeambrun
wrote:
> Hello all,
>
> We just completed the migration of the public API to the new FastAPI
> server, closing a big one https://github.com/apache/airflow/issues/42370.
>
> This new API is feature rich and should feel really familiar
Hello all,
We just completed the migration of the public API to the new FastAPI
server, closing a big one https://github.com/apache/airflow/issues/42370.
This new API is feature rich and should feel really familiar; most
endpoints, parameters and payloads remain the same - Breaking changes are
li
26 matches
Mail list logo
